Switch to Gorilla mux #3343
Closed
Switch to Gorilla mux #3343
+131
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Which kind of version bump are we going to do? v3.4.x? |
khaledez
approved these changes
Sep 8, 2023
tchssk
reviewed
Sep 8, 2023
http/mux.go
Outdated
| enc.Encode(NewErrorResponse(ctx, fmt.Errorf("404 page not found"))) | ||
| } | ||
| return &mux{r} | ||
| r := mux.NewRouter() |
There was a problem hiding this comment.
It needs NotFoundHandler, right?
Suggested change
| r := mux.NewRouter() | |
| r := mux.NewRouter() | |
| r.NotFoundHandler = http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) { | |
| ctx := context.WithValue(req.Context(), AcceptTypeKey, req.Header.Get("Accept")) | |
| enc := ResponseEncoder(ctx, w) | |
| w.WriteHeader(http.StatusNotFound) | |
| enc.Encode(NewErrorResponse(ctx, fmt.Errorf("404 page not found"))) | |
| }) |
After feedback from the community and reviewing potential router candidates, chi seems to be a great default choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gorilla supports a few useful additional features like the ability to retrieve the path template at runtime.