Skip to content

Commit

Permalink
Group v2 update:
Browse files Browse the repository at this point in the history
- Update the grequest services definition. They need to be the same as the relation itself which is group_membership_request. This means that they were not used before.
- Also remove the unsetting of the PermissionProvider permissions. As you would debug in there, these permissions do not exist there anymore so nothing to unset.
  • Loading branch information
Robert Ragas committed Jun 5, 2024
1 parent a5a67af commit cd75ceb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 13 deletions.
10 changes: 5 additions & 5 deletions modules/custom/grequest/grequest.services.yml
Original file line number Diff line number Diff line change
@@ -1,26 +1,26 @@
services:
# Specific group relation handlers.
group.relation_handler.operation_provider.grequest:
group.relation_handler.operation_provider.group_membership_request:
class: 'Drupal\grequest\Plugin\Group\RelationHandler\GroupMembershipRequestOperationProvider'
arguments: [ '@group.relation_handler.operation_provider', '@current_user', '@string_translation' ]
shared: false

group.relation_handler.permission_provider.grequest:
group.relation_handler.permission_provider.group_membership_request:
class: 'Drupal\grequest\Plugin\Group\RelationHandler\GroupMembershipRequestPermissionProvider'
arguments: [ '@group.relation_handler.permission_provider' ]
shared: false

group.relation_handler.post_install.grequest:
group.relation_handler.post_install.group_membership_request:
class: 'Drupal\grequest\Plugin\Group\RelationHandler\GroupMembershipRequestPostInstall'
arguments: [ '@group.relation_handler.post_install', '@entity_type.manager', '@string_translation' ]
shared: false

group.relation_handler.access_control.grequest:
group.relation_handler.access_control.group_membership_request:
class: 'Drupal\grequest\Plugin\Group\RelationHandler\GroupMembershipRequestAccessControl'
arguments: [ '@group.relation_handler.access_control' ]
shared: false

group.relation_handler.entity_reference.grequest:
group.relation_handler.entity_reference.group_membership_request:
class: 'Drupal\grequest\Plugin\Group\RelationHandler\GroupMembershipRequestEntityReference'
arguments: [ '@group.relation_handler.entity_reference' ]
shared: false
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,6 @@ public function buildPermissions() {
'allowed for' => ['outsider'],
];

// These are handled by 'administer members'.
unset($permissions['update own group_membership_request content']);
unset($permissions['view group_membership_request content']);
unset($permissions['create group_membership_request content']);
unset($permissions['update any group_membership_request content']);
unset($permissions['delete any group_membership_request content']);
unset($permissions['delete own group_membership_request content']);

return $permissions;
}

Expand Down

0 comments on commit cd75ceb

Please sign in to comment.