Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3022657 / SHN-267: Add some predefined styles to the CKEditor (full_html) #1152

Merged
merged 2 commits into from Dec 27, 2018

Conversation

jochemvn
Copy link
Contributor

@jochemvn jochemvn commented Dec 7, 2018

Problem

Users sometimes find it difficult to create nice content from the CKeditor.

Solution

Added some predefined styles such as the buttons, so user can create a link and simple set the styl with the dropdown.

Issue tracker

How to test

  • Checkout this branch and revert features
  • Edit a piece of content with the full_html text format. Notice you now have styles.
  • Apply some styles.
  • Save and see the (pretty) result
  • Merge!

Release notes

When editing text as a CM+ there's now an extra dropdown in the editor, that allows you to create nicer links and add some other special Open Social styling to your text.

@jochemvn jochemvn added team: enterprise This PR originates from the ECI team type: feature This PR adds a new feature to Open Social labels Dec 7, 2018
@jochemvn jochemvn changed the title SHN-267: Add some predef SHN-267: Add some predefined styles to the CKEditor (full_html) Dec 7, 2018
@jaapjan jaapjan changed the title SHN-267: Add some predefined styles to the CKEditor (full_html) #3022657 / SHN-267: Add some predefined styles to the CKEditor (full_html) Dec 27, 2018
@jaapjan jaapjan merged commit e7a4361 into 8.x-4.x Dec 27, 2018
@jaapjan jaapjan added this to the 4.2 milestone Dec 27, 2018
@jaapjan
Copy link
Contributor

jaapjan commented Dec 27, 2018

I've merged it and cherry-picked for 5.x. I do think the UX can be improved a bit, but the value is pretty high now. :-)

@jaapjan jaapjan deleted the feature/SHN-267 branch December 27, 2018 11:03
jaapjan pushed a commit that referenced this pull request Dec 27, 2018
… styles to the CKEditor (full_html) (#1152)

#3022657 / SHN-267: Add some predefined styles to the CKEditor (full_html)
@jaapjan jaapjan added the verified-cherry-picks This PR has been cherry-picked to the minor release version label Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: enterprise This PR originates from the ECI team type: feature This PR adds a new feature to Open Social verified-cherry-picks This PR has been cherry-picked to the minor release version
2 participants