Issue #3039170 by Kingdutch: Add styling for tables in content #1249
Conversation
Kingdutch
added
type: feature
Kingdutch
force-pushed
the
feature/3039170-body-text-table-styling
branch
4 times, most recently
from
3991ccb
to
4351e6a
Compare
|
Force pushed to fix the incorrect files being edited and to fix the commit message that was incorrect as a result but ensuring this stays just a single commit instead of a wildly unreadable commit history (fix, fix final, really final fix, etc.). |
Adding a class to user content isn't simple so extending the selector from `.table` (elements with the class table) to also include `.page-node .body-text table` (table elements in elements with the body-text class of node pages) ensures that they're properly styled when using socialbase as a theme.
Kingdutch
force-pushed
the
feature/3039170-body-text-table-styling
branch
from
4351e6a
to
fb62af2
Compare
|
I'm wondering if we should add a change record for this. We are theoretically impacting styling that others already did for their themes right? |
That's actually a good point! I think I agree although I don't know if it would have much more substance than what we put in the release notes. It would be a good highlight. |
|
I don't mind if we say the same as in the release notes, but it would indeed serve as a nice highlight. |
Kingdutch
added
the
needs work: change record
|
A draft change record has been created here: https://www.drupal.org/node/3043143 |
Kingdutch
removed
needs work: change record
|
Given that this is a purely cosmetic change, Travis is green and the MOSS failures are on features that are not impacted by this addition I'm merging this branch in its current test state. |
jaapjan
added
the
backport: verified
Problem
Tables in content (e.g. topic bodies) aren't styled by default which makes them difficult to read.Solution
Adding a class to user content isn't simple so extending the selector from.table(elements with the class table) to also include.page-node .body-text table(table elements in elements with the body-text class of node pages) ensures that they're properly styled when using socialbase as a theme.Issue tracker
https://www.drupal.org/project/social/issues/3039170
How to test
Change record
https://www.drupal.org/node/3043143
Release notes
Tables in content (topic, events, etc.) bodies are now styled by default when using (a subtheme of) the socialbase theme. This improves readability for content that includes tables.