Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3077364 by agami4: Update height of small hero banner for IE #1489

Merged
merged 5 commits into from Sep 30, 2019
Merged

#3077364 by agami4: Update height of small hero banner for IE #1489

merged 5 commits into from Sep 30, 2019

Conversation

Agamich-FE
Copy link
Collaborator

Problem

I choose for Small Hero. This works fine for Chrome but not for IE.

Solution

Update height of small hero for IE

Issue tracker

https://www.drupal.org/project/social/issues/3077364

How to test

  • Change 'Group setting' for hero banner from 'large' to 'small hero'
  • Open group page on the IE browser

Release notes

Small hero banner has correct height on the IE browser

@Agamich-FE Agamich-FE added type: bug Fixes a bug in Open Social team: enterprise This PR originates from the ECI team status: needs review This pull request is waiting for a requested review labels Aug 27, 2019
@Agamich-FE Agamich-FE requested a review from ribel August 27, 2019 09:54
@jaapjan
Copy link
Contributor

jaapjan commented Sep 30, 2019

Merged the 7.x branch back into this to retrigger Travis tests.

@ribel could you please review this? should be fairly small task

ribel
ribel approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@ribel ribel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaapjan I have checked this PR and all looks good to me.
A client with IE11, who reported this bug also verified this and we already use it as a patch in production.

@ribel ribel added prio: medium and removed status: needs review This pull request is waiting for a requested review labels Sep 30, 2019
@ribel ribel added this to the 6.4 milestone Sep 30, 2019
@ribel ribel added the backport: needed This pull request requires a backport to an additionally supported minor version label Sep 30, 2019
@ribel ribel assigned ribel and unassigned ribel Sep 30, 2019
@jaapjan jaapjan merged commit 90b32f6 into 8.x-7.x Sep 30, 2019
@jaapjan jaapjan deleted the bugfix/3077364-small-hero branch September 30, 2019 16:09
jaapjan pushed a commit that referenced this pull request Sep 30, 2019
@Agamich-FE @jaapjan
#3077364 by agami4, jaapjan, ribel: Update height of small hero banne…
7532b21 
…r for IE (#1489)

* #3077364 by agami4: Update height of small hero banner for IE

* YANG-1333: Update styles for small hero banner on the landing page on IE11
@jaapjan jaapjan added the backport: verified This pull request has been back ported to an older minor version label Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ribel ribel ribel approved these changes

Assignees

@ribel ribel

Labels
backport: needed This pull request requires a backport to an additionally supported minor version backport: verified This pull request has been back ported to an older minor version prio: medium team: enterprise This PR originates from the ECI team type: bug Fixes a bug in Open Social
Milestone
6.4
3 participants
@Agamich-FE @jaapjan @ribel