#2994248 Make sure on install SM + CM also need to consent #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronaldtebrake
added
type: bug
|
Marking as needs work since Behat test need to be updated still (since CM/SM now need to give consent 👍 ) https://travis-ci.org/goalgorilla/open_social/jobs/591925204 |
jaapjan
added
status: needs work
…ra permission plus test update for GDPR
ronaldtebrake
added
status: needs review
albertoalaejos
removed
the
status: needs review
jaapjan
added
the
backport: verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SM + CM are not asked to give consent to data policy
Solution
On install of the module both CM + SM get the "without consent" permission so they don't need to consent. I have removed that so it's now only for admin and anon.
I decided this is only for 7.0 and newer installs so current CM + SM aren't disrupted, we can always do it for clients themselves in our own update hook.
Issue tracker
How to test
Release notes
SM and CM now need to consent for GDPR as well, if you want this on your existing platforms make sure CM and SM do not have the "without consent" permission.