Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3085242: remove obsolete font.page.inc and font.html.twig #1531

Merged
merged 1 commit into from Oct 8, 2019

Conversation

jaapjan
Copy link
Contributor

@jaapjan jaapjan commented Oct 2, 2019

Problem

During static code analysis we found that font.page.inc and font.html.twig in the social_font module is actually never called.

Solution

These files were probably auto-generated and may be removed.

Issue tracker

https://www.drupal.org/project/social/issues/3085242

How to test

  • Test the font functionality in socialblue.
  • Make sure everything still works as expected.
  • Login as admin, create a new font via the interface, go to the font list etc.

Release notes

The obsolete font.html.twig and font.page.inc in the social_font module have been removed.

@jaapjan jaapjan added type: refactoring Updates code for improved maintenance without changing its functionality status: needs review This pull request is waiting for a requested review backport: verified This pull request has been back ported to an older minor version shipsters labels Oct 2, 2019
@jaapjan jaapjan added this to the 7.0 milestone Oct 2, 2019
@jaapjan jaapjan merged commit 2577330 into 8.x-7.x Oct 8, 2019
@jaapjan jaapjan deleted the feature/3085242 branch October 8, 2019 14:04
@navneet0693 navneet0693 removed the status: needs review This pull request is waiting for a requested review label Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: verified This pull request has been back ported to an older minor version type: refactoring Updates code for improved maintenance without changing its functionality
3 participants