Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3085803 Added conditional check to account object to be null. #1533

Merged
merged 1 commit into from Oct 8, 2019

Conversation

navneet0693
Copy link
Collaborator

@navneet0693 navneet0693 commented Oct 4, 2019

Problem

In social_profile_privacy_form_alter(), $account is not checked for being NULL when the parameter user is not found in URL. This blocks any user to edit profiles.

Solution

Add a null check.

Issue tracker

https://www.drupal.org/project/social/issues/3085803

How to test

  • Enabled social_profile_privacy module.
  • Login in as SM or admin
  • Go to profile listing
  • Try to edit any profile.

Release notes

Introduces an empty check in social_profile_privacy_form_alter in social_profile_privacy module.

Change Record

N.A

@jaapjan jaapjan merged commit e311d64 into 8.x-7.x Oct 8, 2019
@jaapjan jaapjan deleted the tasks/social_profile_privacy_null_user_account branch October 8, 2019 14:08
@jaapjan jaapjan added bananas type: bug This PR fixes a bug in Open Social status: needs backport The changes in this PR should be included in a minor release version as well labels Oct 8, 2019
@jaapjan jaapjan added this to the 6.4 milestone Oct 8, 2019
jaapjan pushed a commit that referenced this pull request Oct 8, 2019
@ronaldtebrake ronaldtebrake changed the title Added conditional check to account object to be null. Issue #3085803 Added conditional check to account object to be null. Oct 13, 2019
@ronaldtebrake ronaldtebrake added verified-cherry-picks This PR has been cherry-picked to the minor release version and removed status: needs backport The changes in this PR should be included in a minor release version as well labels Oct 13, 2019
@ronaldtebrake
Copy link
Contributor

Also in 6.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug This PR fixes a bug in Open Social verified-cherry-picks This PR has been cherry-picked to the minor release version
3 participants