New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DS-7199 Make module installable from installer #1899
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds `installer_options.yml` to a lot of modules that we currently install on platforms using _core modules. Adding these files to these modules will make them available both to `drush site-install` as well as through the installer UI. This increases discoverability of these modules for distribution users and eases the live of our own SaaS hosting :)
Kingdutch
force-pushed
the
feature/expand-installer-options
branch
from
August 4, 2020 15:09
97e9de4
to
a42ca48
Compare
Kingdutch
added
prio: high
status: needs review
This pull request is waiting for a requested review
team: shipsters
type: feature
Adds a new feature to Open Social
labels
Aug 4, 2020
The force push merged the 9.x changes and fixed a typo in a filename. |
Kingdutch
added
status: needs work
This pull request needs more work before it's ready for review
status: needs review
This pull request is waiting for a requested review
and removed
status: needs review
This pull request is waiting for a requested review
status: needs work
This pull request needs more work before it's ready for review
labels
Aug 4, 2020
Changed status, I thought this failed but the installer options actually work and can be used by Primate. However this reveals some other install issues when enabling all the modules. That should be fixed in a separate issue though.
|
navneet0693
removed
the
status: needs review
This pull request is waiting for a requested review
label
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Open Social includes a lot of optional modules but they may not be easily discovered. Additionally automation applications want to be able to enable these modules during site install.
Solution
This commit adds
installer_options.yml
to a lot of modules that wecurrently install on platforms using _core modules.
Adding these files to these modules will make them available both to
drush site-install
as well as through the installer UI. This increasesdiscoverability of these modules for distribution users and eases the
live of our own SaaS hosting :)
Issue tracker
https://www.drupal.org/project/social/issues/3163317
How to test
For example
Screenshots
n.a.
Release notes
The following modules can now also be chosen during initial site installation: social_gdpr, social_path_manager, social_comment_upload, social_content_block, social_content_report, social_embed, social_event_an_enroll, social_event_enrolments_export, social_event_managers, social_event_max_enroll, social_landing_page, social_group_default_route, social_private_message, social_profile_fields, social_profile_organization_tag, social_profile_privacy, social_tagging, social_user_export