Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-7199 Make module installable from installer #1899

Merged
merged 1 commit into from Aug 5, 2020

Conversation

Kingdutch
Copy link
Member

@Kingdutch Kingdutch commented Jul 8, 2020

Problem

Open Social includes a lot of optional modules but they may not be easily discovered. Additionally automation applications want to be able to enable these modules during site install.

Solution

This commit adds installer_options.yml to a lot of modules that we
currently install on platforms using _core modules.

Adding these files to these modules will make them available both to
drush site-install as well as through the installer UI. This increases
discoverability of these modules for distribution users and eases the
live of our own SaaS hosting :)

Issue tracker

https://www.drupal.org/project/social/issues/3163317

How to test

For example

  • Install all optional modules with our internal project management tool.

Screenshots

n.a.

Release notes

The following modules can now also be chosen during initial site installation: social_gdpr, social_path_manager, social_comment_upload, social_content_block, social_content_report, social_embed, social_event_an_enroll, social_event_enrolments_export, social_event_managers, social_event_max_enroll, social_landing_page, social_group_default_route, social_private_message, social_profile_fields, social_profile_organization_tag, social_profile_privacy, social_tagging, social_user_export

This commit adds `installer_options.yml` to a lot of modules that we
currently install on platforms using _core modules.

Adding these files to these modules will make them available both to
`drush site-install` as well as through the installer UI. This increases
discoverability of these modules for distribution users and eases the
live of our own SaaS hosting :)
@Kingdutch Kingdutch force-pushed the feature/expand-installer-options branch from 97e9de4 to a42ca48 Compare August 4, 2020 15:09
@Kingdutch Kingdutch added this to the 9.0-beta2 milestone Aug 4, 2020
@Kingdutch Kingdutch added prio: high status: needs review This pull request is waiting for a requested review team: shipsters type: feature Adds a new feature to Open Social labels Aug 4, 2020
@Kingdutch Kingdutch marked this pull request as ready for review August 4, 2020 15:30
@Kingdutch
Copy link
Member Author

The force push merged the 9.x changes and fixed a typo in a filename.

@Kingdutch Kingdutch added status: needs work This pull request needs more work before it's ready for review status: needs review This pull request is waiting for a requested review and removed status: needs review This pull request is waiting for a requested review status: needs work This pull request needs more work before it's ready for review labels Aug 4, 2020
@Kingdutch
Copy link
Member Author

Changed status, I thought this failed but the installer options actually work and can be used by Primate.

However this reveals some other install issues when enabling all the modules. That should be fixed in a separate issue though.

Drupal\Core\Config\UnmetDependenciesException: Configuration objects [error] provided by <em class="placeholder">social_featured_content</em> have unmet dependencies: <em class="placeholder">core.entity_view_display.node.page.featured (field.field.node.page.body, field.field.node.page.field_content_visibility, field.field.node.page.field_files, field.field.node.page.field_page_comments, field.field.node.page.field_page_image, node.type.page)</em> in /app/html/core/lib/Drupal/Core/Config/UnmetDependenciesException.php:98 Stack trace: 
#0 /app/html/core/lib/Drupal/Core/Config/ConfigInstaller.php(509): Drupal\Core\Config\UnmetDependenciesException::create('social_featured...', Array) 
#1 /app/html/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php(132): Drupal\Core\Config\ConfigInstaller->checkConfigurationToInstall('module', 'social_featured...') 
#2 /app/html/core/lib/Drupal/Core/Extension/ModuleInstaller.php(161): Drupal\Core\ProxyClass\Config\ConfigInstaller->checkConfigurationToInstall('module', 'social_featured...') 
#3 /app/html/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php(83): Drupal\Core\Extension\ModuleInstaller->install(Array, false) 
#4 /app/html/core/includes/install.core.inc(1877): Drupal\Core\ProxyClass\Extension\ModuleInstaller->install(Array, false) 
#5 /app/html/core/includes/batch.inc(295): _install_module_batch('social_featured...', 'Social Featured...', Array) 
#6 /app/html/core/includes/form.inc(949): _batch_process() 
#7 /app/html/core/includes/install.core.inc(659): batch_process(Object(Drupal\Core\Url), Object(Drupal\Core\Url)) 
#8 /app/html/core/includes/install.core.inc(577): install_run_task(Array, Array) 
#9 /app/html/core/includes/install.core.inc(117): install_run_tasks(Array, NULL) 
#10 /app/vendor/drush/drush/includes/drush.inc(728): install_drupal(Object(Composer\Autoload\ClassLoader), Array) 
#11 /app/vendor/drush/drush/includes/drush.inc(713): drush_call_user_func_array('install_drupal', Array) 
#12 /app/vendor/drush/drush/commands/core/drupal/site_install.inc(82): drush_op('install_drupal', Object(Composer\Autoload\ClassLoader), Array) 
#13 /app/vendor/drush/drush/commands/core/site_install.drush.inc(271): drush_core_site_install_version('social', Array) 
#14 /app/vendor/drush/drush/includes/command.inc(422): drush_core_site_install('social', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'install_configu...', 'install_configu...') 
#15 /app/vendor/drush/drush/includes/command.inc(231): _drush_invoke_hooks(Array, Array) 
#16 /app/vendor/drush/drush/includes/command.inc(199): drush_command('social', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'social_module_c...', 'install_configu...', 'install_configu...') 
#17 /app/vendor/drush/drush/lib/Drush/Boot/BaseBoot.php(67): drush_dispatch(Array) 
#18 /app/vendor/drush/drush/includes/preflight.inc(67): Drush\Boot\BaseBoot->bootstrap_and_dispatch() 
#19 /app/vendor/drush/drush/drush.php(12): drush_main() 
#20 {main} 

@ronaldtebrake ronaldtebrake merged commit 43fab83 into 8.x-9.x Aug 5, 2020
@ronaldtebrake ronaldtebrake deleted the feature/expand-installer-options branch August 5, 2020 07:15
@navneet0693 navneet0693 removed the status: needs review This pull request is waiting for a requested review label Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: high type: feature Adds a new feature to Open Social
3 participants