Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #3164307 by tBKoT: Add the Gin Toolbar module as dependency #1938

Merged
merged 3 commits into from Aug 12, 2020
Merged

Issue #3164307 by tBKoT: Add the Gin Toolbar module as dependency #1938

merged 3 commits into from Aug 12, 2020

Conversation

dmytriikaiun
Copy link
Contributor

Problem

The Gin Toolbar fails to be installed

Solution

Add the Gin toolbar module as a dependencie

Issue tracker

https://www.drupal.org/project/social/issues/3164307

@dmytriikaiun dmytriikaiun added type: bug This PR fixes a bug in Open Social team: enterprise This PR originates from the ECI team type: dependencies Pull requests that update a dependency file prio: critical Critical priority labels Aug 10, 2020
@ribel ribel added this to the 9.0-beta2 milestone Aug 10, 2020
@dmytriikaiun dmytriikaiun changed the title Issue #3164307 by tBKoT: Add the Gin Toolbar module as dependencie Issue #3164307 by tBKoT: Add the Gin Toolbar module as dependency Aug 11, 2020
@ronaldtebrake
Issue #3164307 by ronaldtebrake: Ensure we test this correctly, befor…
c6f987b 
…e without the gin_toolbar the link behatsitemanager would be rendered as part of the toolbar, gin doesnt have this link and fails. However we want to test the main page content to see the author so this covers it better even if admin toolbar was enabled
@ronaldtebrake
Copy link
Contributor

Unfortunately the failing test was related to gin_toolbar.
Before the test would return true on this step:
And I should see the link "behatsitemanager" because it was rendered in the admin_toolbar however with GIN this link is gone, and apparantly it now fails.

Screenshot 2020-08-12 at 14 29 45

Although the link is still there if you test it out locally
Screenshot 2020-08-12 at 14 12 42

So I have now updated the test to And I should see "behatsitemanager" in the "Main content" region
so it actually checks in the region, although it doesnt verify if its a link, i think the main thing we want to check is to see if we can find the author.

@ronaldtebrake
Copy link
Contributor

Thank you so much @ribel @dmytriikaiun works like a charm!

@ronaldtebrake ronaldtebrake merged commit 279c16e into 8.x-9.x Aug 12, 2020
@ronaldtebrake ronaldtebrake deleted the bugfix/3164307-gin-toolbar-fails-to-be-installed branch August 12, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bramtenhove bramtenhove bramtenhove approved these changes

Assignees
No one assigned
Labels
prio: critical Critical priority team: enterprise This PR originates from the ECI team type: bug This PR fixes a bug in Open Social type: dependencies Pull requests that update a dependency file
Milestone
9.0
4 participants
@dmytriikaiun @ronaldtebrake @bramtenhove @ribel