Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3178408 - Add group type field in flexible groups. #2140

Merged
merged 7 commits into from Jan 2, 2021

Conversation

navneet0693
Copy link
Collaborator

@navneet0693 navneet0693 commented Dec 31, 2020

Problem

The user should be able to see the functional group types of the groups.

Solution

  1. Created a new taxonomy “Group type”
  2. SM should be able to add new group types
  3. Make sure SM can enable/disable through a specific settings page in Open Social
  4. Added this setting to the existing Group settings page
  5. Make sure an SM can go directly to the page where Group type terms are added
  6. There are no default terms
  7. Add a new taxonomy term reference with this group type to the Flexible group creation
  8. Label should be Type
  9. It is an optional field, unless we have Group types then we make it a radio required field.

Issue tracker

https://www.drupal.org/project/social/issues/3178408

How to test

  • Install Open Social on 10.0.x or the base branch.
  • Run drush updb -y
  • Check for creation of field "Type" in Flexible group- Manage Fields and Manage Form Display.
  • Go to /admin/config/opensocial/social-group and see if option to enable/disable is there.
  • Enable the option.
  • Add taxonomy terms to 'Group type' vocabulary
  • Create a flexible group
  • Check if the type field appears at the top of the form
  • Check that it is a required fields
  • Disable the options to have 'Type' field appear on the form.
  • Create a flexible group again and check that the option to select a type would disappear.
  • Enable the option but delete the terms in Group type vocabulary
  • Create a flexible group again, see that the option should not appear.

Screenshots

image

image

image

image

image

image

image

image

Release notes

We have added new functionality to define new Group types just like Event/Topic types. We can choose the group type when we add a new flexible group. Also, we have provided the option for a site manager to control the behavior of this field by adding a checkbox in the Group settings page, where it can choose to enable or disable this field.

…or creating new field_group_type in flexible groups.
… new vocabulary 'Group type' and add new fields to existing flexibe group configurations.
…Group settings form for enabling site managers to configuring the options to enable/disable group type option on flexible group add form.
Base automatically changed from feature/3186003-content-form-improvements to 10.0.x December 31, 2020 13:37
@navneet0693 navneet0693 added this to the 10.0 milestone Dec 31, 2020
@navneet0693 navneet0693 added status: needs review This pull request is waiting for a requested review team: nucleus type: refactoring Updates code for improved maintenance without changing its functionality type: feature Adds a new feature to Open Social labels Dec 31, 2020
@navneet0693 navneet0693 marked this pull request as ready for review December 31, 2020 14:09
@ronaldtebrake ronaldtebrake changed the title Issue #3186003 by navneet0693: Added Group type field in flexible groups. Issue #3178408 - Add group type field in flexible groups. Jan 2, 2021
@ronaldtebrake ronaldtebrake merged commit 7b78dac into 10.0.x Jan 2, 2021
@ronaldtebrake ronaldtebrake deleted the feature/3186003-DS-7452-group-type-field branch January 2, 2021 10:16
@ronaldtebrake ronaldtebrake removed the status: needs review This pull request is waiting for a requested review label Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: nucleus type: feature Adds a new feature to Open Social type: refactoring Updates code for improved maintenance without changing its functionality
2 participants