Issue #2880361: Add core patch for correct checking if post_update is hook_post_update_NAME() or hook_update_N().

[ronaldtebrake]

Problem

As mentioned: https://www.drupal.org/project/drupal/issues/548470

The underscore separator in the hook naming is very brittle. If a module invents the foo_bar hook and another invents the bar hook and you also have two modules called something_foo and something then all hell breaks lose. Also, it's impossible to see from a function name whether it's a hook implementation or not (and unless every non-hook implementation function name is carefully prefixed with an underscore, just with enabling another module suddenly it might become one).

We have found an issue with exactly this problem.

It has to do with the fact we have an install profile called social and a module called social_post
This means any regular update hooks (f.e. hook_update_N() or hook_update_dependencies()) used are considered as social module's hook_post_update_NAME(). instead of social_post module's hook_update_%

The same can be done with the standard install profile for example, by creating a standard_post module or any other module with the module_post name.

Solution

For now we propose to at least fix this by adding some inspection in DbUpdateController.php to check if the hook_post_update_NAME function is coming from the correct file module.post_update.php
This aligns with what is indicated when the post update hook can't be found.

For example in our case:
> [warning] Post update function social_post_update_8801 not found in file social.post_update.php

Issue tracker

In Open Social -
https://www.drupal.org/project/social/issues/2880361

In Drupal -
https://www.drupal.org/project/drupal/issues/3236316

How to test

• See that update.php/selection does not show any social_post related update hooks.
• See that update path from an older version of Open Social is still accepted

Release notes

Social post update hooks should now correctly not show up anymore when trying to update.

[navneet0693]

🍒 -picked to 10.3.x