Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3346744 by chmez: Activity without a message #3332

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

OH17L
Copy link
Contributor

@OH17L OH17L commented Mar 8, 2023

Problem

The activity entity field for a relation to the message entity can be empty.

Solution

Ensure that this field is filled during the process of adding theme suggestions by the "Social Follow Taxonomy Term" module.

Issue tracker

How to test

  • It's a tricky case which can be reproduced only sometimes when cron is running. More details can be found in PROD-24498.

@OH17L OH17L added type: bug Fixes a bug in Open Social type: refactoring Updates code for improved maintenance without changing its functionality team: enterprise This PR originates from the ECI team prio: medium team: finalizer labels Mar 8, 2023
@OH17L OH17L added this to the 11.7.4 milestone Mar 8, 2023
@OH17L OH17L self-assigned this Mar 8, 2023
@mergeable
Copy link

mergeable bot commented Mar 8, 2023

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

@OH17L OH17L added the status: needs work This pull request needs more work before it's ready for review label Mar 9, 2023
…relation to the message entity is filled during the process of adding theme suggestions by the "Social Follow Taxonomy Term" module
@OH17L OH17L force-pushed the issue/3346744-activity-without-message branch from 1097c98 to a4e786c Compare March 9, 2023 10:59
@OH17L OH17L marked this pull request as ready for review March 9, 2023 11:31
@OH17L OH17L added status: needs review This pull request is waiting for a requested review and removed status: needs work This pull request needs more work before it's ready for review labels Mar 9, 2023
@OH17L OH17L requested a review from ribel March 9, 2023 11:32
Copy link
Contributor

@ribel ribel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me.
Also it was tested and seems to sole WSOD with cron.

@tbsiqueira tbsiqueira modified the milestones: 11.7.4, 11.7.5 Mar 14, 2023
@nkoporec
Copy link
Contributor

Test is also failing in the main, so its not related to these changes.

@nkoporec nkoporec merged commit 9fa3e08 into main Mar 22, 2023
@nkoporec nkoporec deleted the issue/3346744-activity-without-message branch March 22, 2023 16:13
@nkoporec
Copy link
Contributor

🍒 picked to 11.7.x, 11.8.x

@tbsiqueira tbsiqueira added the backport: verified This pull request has been back ported to an older minor version label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: verified This pull request has been back ported to an older minor version prio: medium status: needs review This pull request is waiting for a requested review team: enterprise This PR originates from the ECI team type: bug Fixes a bug in Open Social type: refactoring Updates code for improved maintenance without changing its functionality
4 participants