Issue #3346912 by zanvidmar: Profile pictures missing on landing page

[zanvidmar]

Profile pictures missing on landing page content type for LU that is not VU.

Problem

This is the FUP of 3237
For authenticated user, which is not verified user, the user profile image is not loaded and appears broken instead of the default placeholder.

Solution

Use permission system instead of role based logic which is not covering all the cases.

Issue tracker

3346912

Theme issue tracker

N/A

How to test

• Using the latest version of Open Social with the social_landing_page and social_private_file social_file_private modules enabled
• Define $settings['file_private_path'] in settings.php
• As a site manager, create a landing page, add "featured content" section and select any profile entities
• When I open the created page as anonymous I expect to see added profiles with default profile images shown.
• When I open the created page as authenticated user without verified user role, I expect to see added profiles with default profile images shown.

Definition of done

Before merge

• Code/peer review is completed
• All commit messages are clear and clean. If applicable a rebase was performed
• All automated tests are green
• Functional/manual tests of the acceptance criteria are approved
• All acceptance criteria were met
• New features or changes to existing features are covered by tests, either unit (preferably) or behat
• Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
• Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
• This pull request has all required labels (team/type/priority)
• This pull request has a milestone
• This pull request has an assignee (if applicable)
• Any front end changes are tested on all major browsers
• New UI elements, or changes on UI elements are approved by the design team
• New features, or feature changes are approved by the product owner

After merge

• Code is tested on all branches that it has been cherry-picked
• Update hook number might need adjustment, make sure they have the correct order
• The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

N/A

Release notes

When the website was using private file, then the profile images appear to be broken on landing pages for Authenticated users without verified user role, if a featured content or a stream view was added. We resolved the access problem for given users and now the default profile picture is displayed.

Change Record

N/A

Translations

N/A

[mergeable]

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

[nkoporec]

LGTM

[nkoporec]

🍒 picked to 11.7.x,11.8.x