Issue #3348281 - Fix expensive calls in config override of Social Follow Tag

[bramtenhove]

Problem

We're doing expensive config gets in overrides and this is also the case for Social Follow Tag.

Solution

Move the if statement that checks for the config name first before executing the config get call.

Issue tracker

https://www.drupal.org/project/social/issues/3348281

Theme issue tracker

N/a

How to test

• Enable social_follow_tag
• Set a breakpoint, check that it's executed quite often.
• Go to this branch, it's only executed a handful of times.

Definition of done

Before merge

• Code/peer review is completed
• All commit messages are clear and clean. If applicable a rebase was performed
• All automated tests are green
• Functional/manual tests of the acceptance criteria are approved
• All acceptance criteria were met
• New features or changes to existing features are covered by tests, either unit (preferably) or behat
• Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
• Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
• This pull request has all required labels (team/type/priority)
• This pull request has a milestone
• This pull request has an assignee (if applicable)
• Any front end changes are tested on all major browsers
• New UI elements, or changes on UI elements are approved by the design team
• New features, or feature changes are approved by the product owner

After merge

• Code is tested on all branches that it has been cherry-picked
• Update hook number might need adjustment, make sure they have the correct order
• The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

N/a

Release notes

We improved performance by reducing the number of config get calls in Social Follow Tag.

Change Record

N/a

Translations

N/a

[mergeable]

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

[tbsiqueira]

Cherry-picked to 11.8.x here c27f547