-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #3353190 by ribel: Add Header top region to the Landing page template #3371
Conversation
Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊 |
@ribel, I've checked if we have the header(header with two rows) on the landing page and everything looks good. |
bbd6730
to
6501338
Compare
…nding Issue #3353190 by ribel: Add Header top region to the Landing page template
…nding Issue #3353190 by ribel: Add Header top region to the Landing page template
🍒 picked to 11.9.x and 11.8.x |
Problem
Header top region is missing from overridden Landing Page template:
page--node--landing-page.html.twig
.Solution
Add rendering of Header top region the same as in base template of socialblue theme: page--sky.html.twig:
Issue tracker
Theme issue tracker
N/A
How to test
Definition of done
Before merge
After merge
Screenshots
Before:
![image](https://user-images.githubusercontent.com/2241917/230890214-884fd2ec-9cc3-41f9-9a2b-fac0dcca1010.png)
![image](https://user-images.githubusercontent.com/2241917/230890015-da5b35e7-5f81-40e2-8614-07369f62d1f2.png)
After:
Release notes
Header top region is now displayed on Landing Pages.
Change Record
N/A
Translations
N/A