Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3353190 by ribel: Add Header top region to the Landing page template #3371

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

ribel
Copy link
Contributor

@ribel ribel commented Apr 10, 2023

Problem

Header top region is missing from overridden Landing Page template: page--node--landing-page.html.twig.

Solution

Add rendering of Header top region the same as in base template of socialblue theme: page--sky.html.twig:

{% if page.header_top and multi_line %}
  {{ page.header_top }}
{% endif %}

Issue tracker

Theme issue tracker

N/A

How to test

  • Enable module Social Landing Page
  • Go to theme settings
  • Enable two-row header style
  • Add some blocks to the Header top region
  • Go to Landing page
  • You should see block in the Header top region

Definition of done

Before merge

  • Code/peer review is completed
  • All commit messages are clear and clean. If applicable a rebase was performed
  • All automated tests are green
  • Functional/manual tests of the acceptance criteria are approved
  • All acceptance criteria were met
  • New features or changes to existing features are covered by tests, either unit (preferably) or behat
  • Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
  • Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
  • This pull request has all required labels (team/type/priority)
  • This pull request has a milestone
  • This pull request has an assignee (if applicable)
  • Any front end changes are tested on all major browsers
  • New UI elements, or changes on UI elements are approved by the design team
  • New features, or feature changes are approved by the product owner

After merge

  • Code is tested on all branches that it has been cherry-picked
  • Update hook number might need adjustment, make sure they have the correct order
  • The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

Before:
image
After:
image

Release notes

Header top region is now displayed on Landing Pages.

Change Record

N/A

Translations

N/A

@mergeable
Copy link

mergeable bot commented Apr 10, 2023

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

@ribel ribel added the type: bug Fixes a bug in Open Social label Apr 10, 2023
@mergeable mergeable bot added blocked: mergeable and removed type: bug Fixes a bug in Open Social labels Apr 10, 2023
@ribel ribel added type: bug Fixes a bug in Open Social team: enterprise This PR originates from the ECI team and removed blocked: mergeable labels Apr 10, 2023
@mergeable mergeable bot removed type: bug Fixes a bug in Open Social team: enterprise This PR originates from the ECI team labels Apr 10, 2023
@ribel ribel added status: needs review This pull request is waiting for a requested review type: bug Fixes a bug in Open Social labels Apr 10, 2023
@mergeable mergeable bot added blocked: mergeable and removed type: bug Fixes a bug in Open Social status: needs review This pull request is waiting for a requested review labels Apr 10, 2023
@ribel ribel added type: bug Fixes a bug in Open Social team: enterprise This PR originates from the ECI team status: needs review This pull request is waiting for a requested review and removed blocked: mergeable labels Apr 10, 2023
@mergeable mergeable bot added blocked: mergeable status: needs review This pull request is waiting for a requested review and removed type: bug Fixes a bug in Open Social team: enterprise This PR originates from the ECI team status: needs review This pull request is waiting for a requested review labels Apr 10, 2023
@ribel ribel added this to the 11.8.3 milestone Apr 10, 2023
@mergeable mergeable bot added type: bug Fixes a bug in Open Social and removed type: bug Fixes a bug in Open Social labels Apr 10, 2023
@ribel ribel added team: enterprise This PR originates from the ECI team prio: medium labels Apr 10, 2023
@ribel ribel added the type: bug Fixes a bug in Open Social label Apr 10, 2023
@ribel ribel requested a review from Agamich-FE April 10, 2023 11:08
@Agamich-FE
Copy link
Collaborator

@ribel, I've checked if we have the header(header with two rows) on the landing page and everything looks good.

@tbsiqueira tbsiqueira modified the milestones: 11.8.3, 11.8.4 Apr 11, 2023
@ribel ribel force-pushed the issue/3353190-header-top-landing branch from bbd6730 to 6501338 Compare April 11, 2023 15:39
@ribel ribel merged commit 5ecbc33 into main Apr 13, 2023
@ribel ribel deleted the issue/3353190-header-top-landing branch April 13, 2023 15:39
ribel added a commit that referenced this pull request Apr 13, 2023
…nding

Issue #3353190 by ribel: Add Header top region to the Landing page template
ribel added a commit that referenced this pull request Apr 13, 2023
…nding

Issue #3353190 by ribel: Add Header top region to the Landing page template
@ribel
Copy link
Contributor Author

ribel commented Apr 13, 2023

🍒 picked to 11.9.x and 11.8.x

@ribel ribel added the backport: verified This pull request has been back ported to an older minor version label Apr 13, 2023
@tbsiqueira tbsiqueira removed the status: needs review This pull request is waiting for a requested review label Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: verified This pull request has been back ported to an older minor version prio: medium team: enterprise This PR originates from the ECI team type: bug Fixes a bug in Open Social
3 participants