Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3366365 by nkoporec: Tag text is cut when using social_follow_tag module and layout builder #3424

Merged
merged 3 commits into from
Jun 19, 2023

Conversation

nkoporec
Copy link
Contributor

Problem

When using the social_follow_tag module together with layout builder and with 2 column layout then the tag text is cut and not displayed correctly.

Solution

Adjust the CSS so that the tag text is not cut off.

Issue tracker

https://www.drupal.org/project/social/issues/3366365

Theme issue tracker

[Required if applicable] Paste a link to the drupal.org theme issue queue item, either from socialbase or socialblue. If any other issue trackers were used, include links to those too.

How to test

  1. Enable social_follow_tag module and create a really long tag name.
  2. Enable layout builder
  3. Create a new page with layout builder and set a 2 column display
  4. In one of the columns add the Social follow tag block and put something in the other (like content block)
  5. Check the tag display.

Definition of done

Before merge

  • Code/peer review is completed
  • All commit messages are clear and clean. If applicable a rebase was performed
  • All automated tests are green
  • Functional/manual tests of the acceptance criteria are approved
  • All acceptance criteria were met
  • New features or changes to existing features are covered by tests, either unit (preferably) or behat
  • Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
  • Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
  • This pull request has all required labels (team/type/priority)
  • This pull request has a milestone
  • This pull request has an assignee (if applicable)
  • Any front end changes are tested on all major browsers
  • New UI elements, or changes on UI elements are approved by the design team
  • New features, or feature changes are approved by the product owner

After merge

  • Code is tested on all branches that it has been cherry-picked
  • Update hook number might need adjustment, make sure they have the correct order
  • The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

Before:
2023-06-13_08-09

After:
2023-06-13_08-13

Release notes

Fixed a styling issue where tag text in social follow tag block would be cut off when using it with layout builder and 2 column layouts.

Change Record

Translations

@nkoporec nkoporec added type: bug Fixes a bug in Open Social status: needs review This pull request is waiting for a requested review prio: low team: guardians labels Jun 13, 2023
@nkoporec nkoporec added this to the 11.8.11 milestone Jun 13, 2023
@mergeable
Copy link

mergeable bot commented Jun 13, 2023

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

@zanvidmar zanvidmar self-requested a review June 16, 2023 14:27
Copy link
Contributor

@zanvidmar zanvidmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanvidmar zanvidmar merged commit 2e7e9ae into main Jun 19, 2023
184 checks passed
@zanvidmar zanvidmar deleted the bug/tag-text-cut-if-too-long branch June 19, 2023 08:46
@zanvidmar
Copy link
Contributor

🍒

Cherry-picked to 11.8.x here: 451b0862e
Cherry-picked to 11.9.x here: 237dccfee

@tbsiqueira tbsiqueira added backport: verified This pull request has been back ported to an older minor version and removed status: needs review This pull request is waiting for a requested review labels Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: verified This pull request has been back ported to an older minor version prio: low team: guardians type: bug Fixes a bug in Open Social
3 participants