Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3370849 by nkoporec: Can't add an image to the existing album on stream page #3442

Conversation

nkoporec
Copy link
Contributor

@nkoporec nkoporec commented Jun 28, 2023

Problem

When using social_album and I want to add an image to stream using the default /stream page, I see that a field widget is displayed to also add this image to an album, but the options there are always "None" or "Create a new album", even if I already have multiple albums created. So it should be possible to select an existing album.

I have multiple public albums created:
2023-06-28_08-28

I don't see them in the field widget:

2023-06-28_08-27

Solution

We need to update the custom field widget to allow selecting an existing albums.

Issue tracker

https://www.drupal.org/project/social/issues/3370849

Theme issue tracker

[Required if applicable] Paste a link to the drupal.org theme issue queue item, either from socialbase or socialblue. If any other issue trackers were used, include links to those too.

How to test

  1. Install social_album
  2. Create a new public album
  3. Go to /stream page and click on 'Add images'
  4. Add an image, you should see the Add image(s) to an album field widget
  5. Try to select an album that you created in step 2.

Definition of done

Before merge

  • Code/peer review is completed
  • All commit messages are clear and clean. If applicable a rebase was performed
  • All automated tests are green
  • Functional/manual tests of the acceptance criteria are approved
  • All acceptance criteria were met
  • New features or changes to existing features are covered by tests, either unit (preferably) or behat
  • Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
  • Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
  • This pull request has all required labels (team/type/priority)
  • This pull request has a milestone
  • This pull request has an assignee (if applicable)
  • Any front end changes are tested on all major browsers
  • New UI elements, or changes on UI elements are approved by the design team
  • New features, or feature changes are approved by the product owner

After merge

  • Code is tested on all branches that it has been cherry-picked
  • Update hook number might need adjustment, make sure they have the correct order
  • The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

Before:
2023-06-28_08-27

After:

image

Release notes

Added the ability to add images directly to existing albums via the stream page.

Change Record

Translations

@mergeable
Copy link

mergeable bot commented Jun 28, 2023

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

@nkoporec nkoporec added the type: bug Fixes a bug in Open Social label Jun 28, 2023
@nkoporec nkoporec added status: needs review This pull request is waiting for a requested review needs: behat review and removed needs: test labels Jun 28, 2023
@zanvidmar zanvidmar self-requested a review June 29, 2023 08:37
Copy link
Contributor

@zanvidmar zanvidmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments in code. Thank you 🙂

I did functional testing and this works as designed 👍

@BiaInacio
Copy link
Contributor

Change is working as expected!
image

@nkoporec nkoporec force-pushed the bug/issue-3370849/cant-add-images-to-existing-albums-via-stream-page branch from f3a311e to 10acc5b Compare July 5, 2023 14:22
@zanvidmar zanvidmar merged commit f796f4d into main Jul 5, 2023
189 checks passed
@zanvidmar zanvidmar deleted the bug/issue-3370849/cant-add-images-to-existing-albums-via-stream-page branch July 5, 2023 16:14
@zanvidmar
Copy link
Contributor

🍒 cherry picked

Cherry-picked to 11.8.x here: 0c2e368fc
Cherry-picked to 11.9.x here: 655c43dca

@zanvidmar zanvidmar added backport: verified This pull request has been back ported to an older minor version status: no action needed and removed needs: behat review status: needs review This pull request is waiting for a requested review labels Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: verified This pull request has been back ported to an older minor version prio: medium team: guardians type: bug Fixes a bug in Open Social
3 participants