-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #3370849 by nkoporec: Can't add an image to the existing album on stream page #3442
Issue #3370849 by nkoporec: Can't add an image to the existing album on stream page #3442
Conversation
Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊 |
tests/behat/features/capabilities/post/post-album-existing.feature
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments in code. Thank you 🙂
I did functional testing and this works as designed 👍
f3a311e
to
10acc5b
Compare
Problem
When using social_album and I want to add an image to stream using the default /stream page, I see that a field widget is displayed to also add this image to an album, but the options there are always "None" or "Create a new album", even if I already have multiple albums created. So it should be possible to select an existing album.
I have multiple public albums created:
I don't see them in the field widget:
Solution
We need to update the custom field widget to allow selecting an existing albums.
Issue tracker
https://www.drupal.org/project/social/issues/3370849
Theme issue tracker
[Required if applicable] Paste a link to the drupal.org theme issue queue item, either from socialbase or socialblue. If any other issue trackers were used, include links to those too.
How to test
Add image(s) to an album
field widgetDefinition of done
Before merge
After merge
Screenshots
Before:
After:
Release notes
Added the ability to add images directly to existing albums via the stream page.
Change Record
Translations