Issue #3373122 by SV: Users profile images not shown in email notifications

[volodymyr-sydor]

Problem

Currently when receiving emails with notifications, for example when someone joined a group It will show a broken profile image

Solution

Looks like lazyload causes that issue and needs to disable in the related email template
Also, if image is not public then need to show default placeholder image

Issue tracker

• https://www.drupal.org/project/social/issues/3373122
• https://getopensocial.atlassian.net/browse/PROD-25496

Theme issue tracker

N/A

How to test

• Using the latest version of Open Social with the lazy-related modules enabled
• As a sitemanager
• Try to create a flexible group
• Then, with a second account, join this group
• When I receive notification emails I expect to see a user profile image but instead see a broken one.
• The expected result is attained when repeating the steps with this fix applied.

Definition of done

Before merge

• Code/peer review is completed
• All commit messages are clear and clean. If applicable a rebase was performed
• All automated tests are green
• Functional/manual tests of the acceptance criteria are approved
• All acceptance criteria were met
• New features or changes to existing features are covered by tests, either unit (preferably) or behat
• Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
• Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
• This pull request has all required labels (team/type/priority)
• This pull request has a milestone
• This pull request has an assignee (if applicable)
• Any front end changes are tested on all major browsers
• New UI elements, or changes on UI elements are approved by the design team
• New features, or feature changes are approved by the product owner

After merge

• Code is tested on all branches that it has been cherry-picked
• Update hook number might need adjustment, make sure they have the correct order
• The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

Before

After:

Release notes

Fixes an issue with broken profile image in the email notification

Change Record

N/A

Translations

N/A

[mergeable]

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

[ribel]

Changes were tested and looks good to me.

[tbsiqueira]

Code is approved, let's wait for functional tests

[tbsiqueira]

Is it possible to create behat tests for this? We have access to the email content

[volodymyr-sydor]

Is it possible to create behat tests for this? We have access to the email content

theoretically yes, but I guess could be some "pitfalls" because here we needed an email with an attachment
I will check and if wouldn't any blocker I'll try to add it

[ribel]

🍒 picked to 11.10.x and 11.9.x (conflicts were resolved)

[volodymyr-sydor]

Is it possible to create behat tests for this? We have access to the email content

I've checked it and faced with a few issues/blockers:

• currently, a notification-emails.feature is disabled for some reason
• we don't have any other similar test scenario for join roup (only invitation) that we can adjust
• the current method findSubjectAndBody() checks only the subject and skip a body
• and if we try to get a email about joining group that email will be without an attachment

So, looks like for the current moment it should be postponed