Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3386542 by nkoporec: Update drupal/csv_serialization from 2.x to 3.x #3518

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

nkoporec
Copy link
Contributor

@nkoporec nkoporec commented Sep 11, 2023

Problem

It is not possible to support both Drupal 9.x and 10.x in a single release of this module due to a breaking change in EncoderInterface::encode() between Symfony 4.4 (D9) and Symfony 6.2 (D10). When preparing for an upgrade to Drupal 10 we need to widen Composer version constraints to allow either 2.x or 3.x: composer require drupal/csv_serialization:^2.0 || ^3.0. This will allow the module to be automatically upgraded when you upgrade Drupal core.

Changelists:

https://git.drupalcode.org/project/csv_serialization/-/commits/3.x?ref_t...

Solution

Allow 3.x version in composer.json

Issue tracker

https://www.drupal.org/project/social/issues/3386542

Theme issue tracker

[Required if applicable] Paste a link to the drupal.org theme issue queue item, either from socialbase or socialblue. If any other issue trackers were used, include links to those too.

How to test

  • Set up Open Social
  • Enable social_user_export
  • Go to /admin/people and select users
  • Run VBO action 'Export selected users to CSV'
  • Check that the CSV file is correct

Definition of done

Before merge

  • Code/peer review is completed
  • All commit messages are clear and clean. If applicable a rebase was performed
  • All automated tests are green
  • Functional/manual tests of the acceptance criteria are approved
  • All acceptance criteria were met
  • New features or changes to existing features are covered by tests, either unit (preferably) or behat
  • Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
  • Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
  • This pull request has all required labels (team/type/priority)
  • This pull request has a milestone
  • This pull request has an assignee (if applicable)
  • Any front end changes are tested on all major browsers
  • New UI elements, or changes on UI elements are approved by the design team
  • New features, or feature changes are approved by the product owner

After merge

  • Code is tested on all branches that it has been cherry-picked
  • Update hook number might need adjustment, make sure they have the correct order
  • The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

Release notes

Update drupal/csv_serialization module to latest version.

Change Record

Translations

@nkoporec nkoporec added type: update status: needs review This pull request is waiting for a requested review prio: medium team: guardians labels Sep 11, 2023
@nkoporec nkoporec added this to the 11.10.1 milestone Sep 11, 2023
@mergeable
Copy link

mergeable bot commented Sep 11, 2023

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

Copy link
Contributor

@vcsvinicius vcsvinicius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nkoporec I approved this pull-request

@vcsvinicius vcsvinicius added needs: test and removed status: needs review This pull request is waiting for a requested review labels Sep 12, 2023
@BiaInacio
Copy link
Contributor

Update works as expected!
image

@nkoporec nkoporec merged commit 50c32d3 into main Sep 14, 2023
191 checks passed
@nkoporec nkoporec deleted the issue/3386542/update-csv-serialization-to-3-x branch September 14, 2023 05:27
@tbsiqueira tbsiqueira modified the milestones: 11.10.1, 12.0.0-alpha1 Sep 18, 2023
@ronaldtebrake ronaldtebrake modified the milestones: 12.0.0-alpha1, 11.11.0 Oct 9, 2023
@Kingdutch Kingdutch added type: dependencies Updating a dependency file needs work: tests This pull request is missing test coverage and removed type: update labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs work: tests This pull request is missing test coverage prio: medium team: guardians type: dependencies Updating a dependency file
6 participants