Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3406255 by SV: Display translated "commented content type" on the stream/email notification #3631

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

volodymyr-sydor
Copy link
Contributor

@volodymyr-sydor volodymyr-sydor commented Dec 5, 2023

Problem

When the user comments on content, "topic" (or also event, discussion, idea) displays untranslated on the stream/email notification.

Solution

Use entity type label in related token to get translated data on the stream/email.

Issue tracker

Theme issue tracker

How to test

  • Using the latest version of Open Social with the social_comment module enabled
  • As a sitemanager
  • Try to add comment to any content (topic, event, discussion,idea) of any user with different language then default one
  • After running cron, I expect that the author of commented node received an email with correct translation of commented entity tyoe
  • The expected result is attained when repeating the steps with this fix applied.

Definition of done

Before merge

  • Code/peer review is completed
  • All commit messages are clear and clean. If applicable a rebase was performed
  • All automated tests are green
  • Functional/manual tests of the acceptance criteria are approved
  • All acceptance criteria were met
  • New features or changes to existing features are covered by tests, either unit (preferably) or behat
  • Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
  • Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
  • This pull request has all required labels (team/type/priority)
  • This pull request has a milestone
  • This pull request has an assignee (if applicable)
  • Any front end changes are tested on all major browsers
  • New UI elements, or changes on UI elements are approved by the design team
  • New features, or feature changes are approved by the product owner

After merge

  • Code is tested on all branches that it has been cherry-picked
  • Update hook number might need adjustment, make sure they have the correct order
  • The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

Before:
Screenshot 2023-12-05 at 16 35 03-1

After:
Screenshot 2023-12-05 at 16 35 16

Release notes

Fixes translations of entity type name on the stream/email notification.

Change Record

N/A

Translations

N/A

@volodymyr-sydor volodymyr-sydor added type: bug Fixes a bug in Open Social team: enterprise This PR originates from the ECI team status: needs work This pull request needs more work before it's ready for review prio: medium labels Dec 5, 2023
@volodymyr-sydor volodymyr-sydor added this to the 12.0.0-rc7 milestone Dec 5, 2023
@volodymyr-sydor volodymyr-sydor self-assigned this Dec 5, 2023
Copy link

mergeable bot commented Dec 5, 2023

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

@volodymyr-sydor volodymyr-sydor force-pushed the bugfix/3406255-translate-bundle-name branch from b0ce5bc to f19dd8f Compare December 5, 2023 15:01
@volodymyr-sydor volodymyr-sydor added status: needs review This pull request is waiting for a requested review and removed status: needs work This pull request needs more work before it's ready for review labels Dec 6, 2023
@volodymyr-sydor volodymyr-sydor marked this pull request as ready for review December 6, 2023 15:36
Copy link
Contributor

@ribel ribel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes were tested and works as expected now.
image

@ribel ribel merged commit 514d96b into main Dec 7, 2023
188 checks passed
@ribel ribel deleted the bugfix/3406255-translate-bundle-name branch December 7, 2023 16:39
@ronaldtebrake ronaldtebrake added the backport: verified This pull request has been back ported to an older minor version label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: verified This pull request has been back ported to an older minor version prio: medium status: needs review This pull request is waiting for a requested review team: enterprise This PR originates from the ECI team type: bug Fixes a bug in Open Social
3 participants