Issue #3419262 by nkoporec : Render context is empty , because render() was called outside of a renderRoot()

[nkoporec]

Problem

We are seeing a lot of this errors and I think they are originated from social_profile_preview_preprocess_field__field_activity_output_text since we are using render() there.

Solution

Replace render with renderPlain

Issue tracker

https://www.drupal.org/project/social/issues/3419262

Theme issue tracker

How to test

1. As a user 1 create a new post on the stream
2. As a user 2 comment on the post.
3. Run cron so the activities will be created
4. Check the email that is send to user 1, and make sure its displayed correctly.

Definition of done

Before merge

• Code/peer review is completed
• All commit messages are clear and clean. If applicable a rebase was performed
• All automated tests are green
• Functional/manual tests of the acceptance criteria are approved
• All acceptance criteria were met
• New features or changes to existing features are covered by tests, either unit (preferably) or behat
• Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
• Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
• This pull request has all required labels (team/type/priority)
• This pull request has a milestone
• This pull request has an assignee (if applicable)
• Any front end changes are tested on all major browsers
• New UI elements, or changes on UI elements are approved by the design team
• New features, or feature changes are approved by the product owner

After merge

• Code is tested on all branches that it has been cherry-picked
• Update hook number might need adjustment, make sure they have the correct order
• The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

Release notes

Change Record

Translations

[mergeable]

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

[vcsvinicius]

I approved the PR

[BiaInacio]

Test done, emails are sent with the right style!

[ronaldtebrake]

Considering we got the approvals I'll merge and cherry-pick!

[ronaldtebrake]

In 12.0.x, 12.1.x and 12.2.x 🍒