Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3420098: Remove references to public_group, open_group, closed_group, and secret_group for social_book module #3773

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

Kingdutch
Copy link
Member

Problem

We're removing the old group types from Open Social. This module has some references to the old group types which should be removed.

Solution

Evaluate the references to the old group types. We might be able to remove the functionality that exists around it altogether and remove the dependency on any group type. If that's not possible just remove the references to the old group type. In any case the functionality itself should keep working for flexible groups.

Issue tracker

https://www.drupal.org/project/social/issues/3420098

Theme issue tracker

How to test

  • Book creation in group works as expected

Definition of done

Before merge

  • Code/peer review is completed
  • All commit messages are clear and clean. If applicable a rebase was performed
  • All automated tests are green
  • Functional/manual tests of the acceptance criteria are approved
  • All acceptance criteria were met
  • New features or changes to existing features are covered by tests, either unit (preferably) or behat
  • Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
  • Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
  • This pull request has all required labels (team/type/priority)
  • This pull request has a milestone
  • This pull request has an assignee (if applicable)
  • Any front end changes are tested on all major browsers
  • New UI elements, or changes on UI elements are approved by the design team
  • New features, or feature changes are approved by the product owner

After merge

  • Code is tested on all branches that it has been cherry-picked
  • Update hook number might need adjustment, make sure they have the correct order
  • The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

Release notes

The references to specific group types have been removed from the user view modes in social_book.

Change Record

Translations

…_group, and secret_group for social_book module
@Kingdutch Kingdutch added type: refactoring Updates code for improved maintenance without changing its functionality team: enterprise This PR originates from the ECI team status: needs review This pull request is waiting for a requested review prio: medium labels Feb 16, 2024
@Kingdutch Kingdutch added this to the 13.0.0 milestone Feb 16, 2024
Copy link

mergeable bot commented Feb 16, 2024

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

@ribel ribel requested a review from nechai February 19, 2024 08:40
@ribel ribel merged commit 7899c33 into main Feb 20, 2024
189 checks passed
@ribel ribel deleted the issue/3420098-remove-group-social_book branch February 20, 2024 15:12
@ronaldtebrake ronaldtebrake modified the milestones: 13.0.0, 13.0.0-alpha1 Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: medium status: needs review This pull request is waiting for a requested review team: enterprise This PR originates from the ECI team type: refactoring Updates code for improved maintenance without changing its functionality
4 participants