Issue #3420102: Remove references to public_group, open_group, closed_group, and secret_group for activity_viewer module

[Kingdutch]

⚠️ Should be merged after #3775

Problem

We're removing the old group types from Open Social. This module has some references to the old group types which should be removed.

Solution

Evaluate the references to the old group types. We might be able to remove the functionality that exists around it altogether and remove the dependency on any group type. If that's not possible just remove the references to the old group type. In any case the functionality itself should keep working for flexible groups.

We don't currently touch the very complex queries in these classes since they touch important access handling. This leads to leaving behind slightly messier code than we might like but we keep focused on the scope of removing the old group types.

Issue tracker

https://www.drupal.org/project/social/issues/3420102

Theme issue tracker

How to test

• The different places in which stream items are shown for groups should remain the same

Definition of done

Before merge

• Code/peer review is completed
• All commit messages are clear and clean. If applicable a rebase was performed
• All automated tests are green
• Functional/manual tests of the acceptance criteria are approved
• All acceptance criteria were met
• New features or changes to existing features are covered by tests, either unit (preferably) or behat
• Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
• Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
• This pull request has all required labels (team/type/priority)
• This pull request has a milestone
• This pull request has an assignee (if applicable)
• Any front end changes are tested on all major browsers
• New UI elements, or changes on UI elements are approved by the design team
• New features, or feature changes are approved by the product owner

After merge

• Code is tested on all branches that it has been cherry-picked
• Update hook number might need adjustment, make sure they have the correct order
• The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

Release notes

The references to specific group types have been removed from the user view modes in activity_viewer.

Change Record

Translations

[mergeable]

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊