Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3427929: Add Configuration Page from Social Follow User to Dashboard Configuration Menu #3817

Conversation

vcsvinicius
Copy link
Contributor

@vcsvinicius vcsvinicius commented Mar 14, 2024

Problem

The configuration page to enable Follow User from Social Follow User module is in Administrator menu, but, ins't in Dashboard Configuration menu.

The site-managers don't have a menu to access this page, only by url.

Solution

Add a menu for Configuration Follow User to Dashboard Configuration.
Menu should be: Dashboard -> Configuration -> Follow user settings

Issue tracker

PROD-28519
#3427929

Theme issue tracker

N/A

How to test

  • Enable Social Follow User module
  • Check menu: Dashboard -> Configuration -> Follow User Settings

Definition of done

Before merge

  • Code/peer review is completed
  • All commit messages are clear and clean. If applicable a rebase was performed
  • All automated tests are green
  • Functional/manual tests of the acceptance criteria are approved
  • All acceptance criteria were met
  • New features or changes to existing features are covered by tests, either unit (preferably) or behat
  • Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
  • Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
  • This pull request has all required labels (team/type/priority)
  • This pull request has a milestone
  • This pull request has an assignee (if applicable)
  • Any front end changes are tested on all major browsers
  • New UI elements, or changes on UI elements are approved by the design team
  • New features, or feature changes are approved by the product owner

After merge

  • Code is tested on all branches that it has been cherry-picked
  • Update hook number might need adjustment, make sure they have the correct order
  • The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

N/A

Release notes

The Follow Uset Settings was added to Dashboard -> Configuration menu and it will be visible to site-manager user.

Change Record

N/A

Translations

N/A

@vcsvinicius vcsvinicius added status: needs review This pull request is waiting for a requested review prio: medium type: repository Improvements to working with the repository (e.g. templates, README files, or workflows) team: guardians labels Mar 14, 2024
@vcsvinicius vcsvinicius added this to the 13.0.0 milestone Mar 14, 2024
@vcsvinicius vcsvinicius requested a review from a team March 14, 2024 17:55
Copy link

mergeable bot commented Mar 14, 2024

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

@ronaldtebrake ronaldtebrake modified the milestones: 13.0.0, 12.3.0 Mar 15, 2024
@ronaldtebrake
Copy link
Contributor

Works like a charm!

Perhaps we can also update

  public function buildForm(array $form, FormStateInterface $form_state): array {
    $form['status'] = [
      '#type' => 'checkbox',
      '#title' => $this->t('Active'),
      '#default_value' => $this->config('social_follow_user.settings')->get('status'),
    ];

While we are at it, just to make sure it is a bit more user friendly.

Adding a description which states it activate / deactives the follow user functionality.

@ronaldtebrake ronaldtebrake modified the milestones: 12.3.0, 12.4.0 Mar 19, 2024
@BiaInacio
Copy link
Contributor

Test done, menu item is displayed!
image

@vcsvinicius vcsvinicius merged commit db05a44 into main Mar 19, 2024
188 checks passed
@vcsvinicius vcsvinicius deleted the feature/3427929/add-menu-to-follow-user-settings-on-dashboard-menu branch March 19, 2024 19:07
@vcsvinicius vcsvinicius added the backport: verified This pull request has been back ported to an older minor version label Mar 19, 2024
@vcsvinicius
Copy link
Contributor Author

I cherry-picked to 12.4.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: verified This pull request has been back ported to an older minor version prio: medium status: needs review This pull request is waiting for a requested review team: guardians type: repository Improvements to working with the repository (e.g. templates, README files, or workflows)
3 participants