Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3431340: Apply patch to fix SocialBlue theme bug #3822

Merged

Conversation

vcsvinicius
Copy link
Contributor

@vcsvinicius vcsvinicius commented Mar 18, 2024

Problem

The custom color isn't be applied to logged user on Search page, a patch with fix was created at #3427426

Solution

Apply patch to fix SocialBlue theme bug

Issue tracker

PROD-28354
#3431340

Theme issue tracker

#3427426

How to test

  • Disable cache for CSS file;
  • Change default color on Social Blue settings;
  • Access the Search Page with Logged and Anonymous User

This errors isn't happen to all installation.

Definition of done

Before merge

  • Code/peer review is completed
  • All commit messages are clear and clean. If applicable a rebase was performed
  • All automated tests are green
  • Functional/manual tests of the acceptance criteria are approved
  • All acceptance criteria were met
  • New features or changes to existing features are covered by tests, either unit (preferably) or behat
  • Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
  • Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
  • This pull request has all required labels (team/type/priority)
  • This pull request has a milestone
  • This pull request has an assignee (if applicable)
  • Any front end changes are tested on all major browsers
  • New UI elements, or changes on UI elements are approved by the design team
  • New features, or feature changes are approved by the product owner

After merge

  • Code is tested on all branches that it has been cherry-picked
  • Update hook number might need adjustment, make sure they have the correct order
  • The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

N/A

Release notes

The bug about custom-color on Search Page will be fixed.

Change Record

N/A

Translations

N/A

@vcsvinicius vcsvinicius added type: bug Fixes a bug in Open Social status: needs review This pull request is waiting for a requested review prio: high team: guardians labels Mar 18, 2024
@vcsvinicius vcsvinicius added this to the 12.3.0 milestone Mar 18, 2024
@vcsvinicius vcsvinicius requested a review from a team March 18, 2024 14:54
@BiaInacio
Copy link
Contributor

Site color is changed even when the CSS cache is disabled!
image

image

@ribel ribel modified the milestones: 12.3.0, 12.1.5 Mar 19, 2024
@ribel ribel self-requested a review March 19, 2024 09:35
Copy link
Contributor

@ribel ribel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ronaldtebrake,
I see theme PR was approved by @agami4, so I assume it's good enough to be merged?

@ronaldtebrake ronaldtebrake modified the milestones: 12.1.5, 12.2.3 Mar 19, 2024
@vcsvinicius vcsvinicius merged commit e1a3a77 into main Mar 19, 2024
188 checks passed
@vcsvinicius vcsvinicius deleted the feature/3431340/apply-patch-tp-fix-color-on-search-page branch March 19, 2024 18:05
@vcsvinicius vcsvinicius added the backport: verified This pull request has been back ported to an older minor version label Mar 19, 2024
@vcsvinicius
Copy link
Contributor Author

I cherry-picked to: 12.2.x, 12.3.x and 12.4.x,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: verified This pull request has been back ported to an older minor version prio: high status: needs review This pull request is waiting for a requested review team: guardians type: bug Fixes a bug in Open Social
4 participants