Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3432522: Remove deprecated modules and functions #3826

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

vcsvinicius
Copy link
Contributor

@vcsvinicius vcsvinicius commented Mar 20, 2024

Problem

We are preparing the code for 13.0.0 version and we need to remove all deprecated modules and functions.

Solution

Remove deprecated modules and functions to be removed from 13.0.0.

Issue tracker

PROD-28595
#3432522

Theme issue tracker

N/A

How to test

Social Event

  • Create an event
  • Invite an user by email

Social Max Enrollment

  • Enable module: Social Event Max Enrollment
  • Create an event and set a max enrollment
  • Test Max Enrollment feature

Social Group

  • Regression test of Social Group feature

Definition of done

Before merge

  • Code/peer review is completed
  • All commit messages are clear and clean. If applicable a rebase was performed
  • All automated tests are green
  • Functional/manual tests of the acceptance criteria are approved
  • All acceptance criteria were met
  • New features or changes to existing features are covered by tests, either unit (preferably) or behat
  • Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
  • Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
  • This pull request has all required labels (team/type/priority)
  • This pull request has a milestone
  • This pull request has an assignee (if applicable)
  • Any front end changes are tested on all major browsers
  • New UI elements, or changes on UI elements are approved by the design team
  • New features, or feature changes are approved by the product owner

After merge

  • Code is tested on all branches that it has been cherry-picked
  • Update hook number might need adjustment, make sure they have the correct order
  • The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

N/A

Release notes

  • Add group isn't have Group Type, should be redirect to Flexible Group automaticly;
  • Removed deprecated function, the depreciation was notified in before versions;

Change Record

N/A

Translations

N/A

@vcsvinicius vcsvinicius added this to the 13.0.0 milestone Mar 20, 2024
@vcsvinicius vcsvinicius requested a review from a team March 20, 2024 22:37
Copy link

mergeable bot commented Mar 20, 2024

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

@vcsvinicius vcsvinicius force-pushed the feature/3432522/remove-deprecated-function-and-module-to-be-removed-os-13 branch from 0441962 to c4783b5 Compare March 21, 2024 12:04
@vcsvinicius vcsvinicius changed the title [WIP][DON'T MERGE] Issue #3432522: Remove deprecated modules and functions Issue #3432522: Remove deprecated modules and functions Mar 21, 2024
@vcsvinicius vcsvinicius added type: feature Adds a new feature to Open Social status: needs review This pull request is waiting for a requested review prio: medium team: guardians and removed blocked: mergeable labels Mar 21, 2024
@mergeable mergeable bot added blocked: mergeable and removed type: feature Adds a new feature to Open Social status: needs review This pull request is waiting for a requested review prio: medium team: guardians blocked: mergeable labels Mar 21, 2024
@vcsvinicius vcsvinicius added type: feature Adds a new feature to Open Social status: needs review This pull request is waiting for a requested review prio: medium team: guardians and removed blocked: mergeable labels Mar 21, 2024
@vcsvinicius vcsvinicius force-pushed the feature/3432522/remove-deprecated-function-and-module-to-be-removed-os-13 branch 3 times, most recently from 18a1ae9 to a60974f Compare March 22, 2024 17:06
@BiaInacio
Copy link
Contributor

Enrollees block count is breaking when an user is invited via email:
image

@vcsvinicius vcsvinicius force-pushed the feature/3432522/remove-deprecated-function-and-module-to-be-removed-os-13 branch from a60974f to bf9d60a Compare April 19, 2024 13:14
@BiaInacio
Copy link
Contributor

Event scenarios are working as expected!
image
image
Group feature is working as expected too!
image

@ronaldtebrake ronaldtebrake force-pushed the feature/3432522/remove-deprecated-function-and-module-to-be-removed-os-13 branch from bf9d60a to e8455de Compare April 23, 2024 08:20
@ronaldtebrake ronaldtebrake modified the milestones: 13.0.0, 13.0.0-alpha2 Apr 23, 2024
@vcsvinicius vcsvinicius force-pushed the feature/3432522/remove-deprecated-function-and-module-to-be-removed-os-13 branch from e8455de to 6d131c6 Compare May 14, 2024 18:09
@open-social-tugboat
Copy link

Tugboat has finished building the preview for this pull request!

Link:

Dashboard:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: medium status: needs review This pull request is waiting for a requested review team: guardians type: feature Adds a new feature to Open Social
5 participants