Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3437440: Block with enrollments from Event page is showing wrong count #3841

Merged

Conversation

vcsvinicius
Copy link
Contributor

@vcsvinicius vcsvinicius commented Apr 1, 2024

Problem

The enrollments count from Event page is showing all enrollments without check the status for invite or pending request.

Solution

Removed parameters to ignore status from events

Issue tracker

Theme issue tracker

PROD-28692
#3437440

How to test

  • Create an event
  • Add an enrollee to the event
  • Invite another user to the event
  • Check the event page
  • The Enrollees block states that the event has two enrollees on the event when there is only one displayed

Definition of done

Before merge

  • Code/peer review is completed
  • All commit messages are clear and clean. If applicable a rebase was performed
  • All automated tests are green
  • Functional/manual tests of the acceptance criteria are approved
  • All acceptance criteria were met
  • New features or changes to existing features are covered by tests, either unit (preferably) or behat
  • Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
  • Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
  • This pull request has all required labels (team/type/priority)
  • This pull request has a milestone
  • This pull request has an assignee (if applicable)
  • Any front end changes are tested on all major browsers
  • New UI elements, or changes on UI elements are approved by the design team
  • New features, or feature changes are approved by the product owner

After merge

  • Code is tested on all branches that it has been cherry-picked
  • Update hook number might need adjustment, make sure they have the correct order
  • The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

N/A

Release notes

Fixed the enrollments count from event page.

Change Record

N/A

Translations

N/A

@vcsvinicius vcsvinicius added type: bug Fixes a bug in Open Social status: needs review This pull request is waiting for a requested review prio: medium team: guardians labels Apr 1, 2024
@vcsvinicius vcsvinicius added this to the 12.3.3 milestone Apr 1, 2024
@vcsvinicius vcsvinicius requested a review from a team April 1, 2024 19:09
Copy link

mergeable bot commented Apr 1, 2024

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

@vcsvinicius vcsvinicius changed the title Removed parameters to ignore status from get-all-enrollments for an e… Issue #3437440: Block with enrollments from Event page is showing wrong count Apr 1, 2024
@vcsvinicius vcsvinicius force-pushed the bugfix/3437440/block-enrollment-count-from-event-page-wrong branch 2 times, most recently from 3e45c36 to dbd4788 Compare April 2, 2024 12:02
@BiaInacio
Copy link
Contributor

Enrollees count is right even when there are pending invites!
image
image

@robertragas robertragas force-pushed the bugfix/3437440/block-enrollment-count-from-event-page-wrong branch from 9a0e537 to 0960af2 Compare April 8, 2024 08:08
@robertragas robertragas merged commit 0769add into main Apr 8, 2024
187 checks passed
@robertragas robertragas deleted the bugfix/3437440/block-enrollment-count-from-event-page-wrong branch April 8, 2024 09:14
@robertragas
Copy link
Contributor

Approved/merged and cherry-picked to 12.4.x and 12.3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: medium status: needs review This pull request is waiting for a requested review team: guardians type: bug Fixes a bug in Open Social
3 participants