Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3440125 | Add patch to fix the serialization issue with GraphQL #3857

Closed

Conversation

tbsiqueira
Copy link
Contributor

@tbsiqueira tbsiqueira commented Apr 11, 2024

Problem

When serializing a big GraphQL schema we see an issue:

Warning: unserialize(): Maximum depth of 4096 exceeded. The depth limit can be changed using the max_depth unserialize() option or the unserialize_max_depth ini setting in Drupal\Component\Serialization\PhpSerialize::decode() (line 21 of /app/html/core/lib/Drupal/Component/Serialization/PhpSerialize.php)

Solution

GraphQL module resolved the issue on version 4.7.0 but this is not yet updated on Open Social, we can host a patch and apply it to Open Social

Original issue: drupal-graphql/graphql#1364

Issue tracker

https://www.drupal.org/project/social/issues/3440125

Theme issue tracker

N/A

How to test

  • Using a very big schema, enable social social_graphql and try to query the API, a serialization will happen

Definition of done

Before merge

  • Code/peer review is completed
  • All commit messages are clear and clean. If applicable a rebase was performed
  • All automated tests are green
  • Functional/manual tests of the acceptance criteria are approved
  • All acceptance criteria were met
  • New features or changes to existing features are covered by tests, either unit (preferably) or behat
  • Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
  • Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
  • This pull request has all required labels (team/type/priority)
  • This pull request has a milestone
  • This pull request has an assignee (if applicable)
  • Any front end changes are tested on all major browsers
  • New UI elements, or changes on UI elements are approved by the design team
  • New features, or feature changes are approved by the product owner

After merge

  • Code is tested on all branches that it has been cherry-picked
  • Update hook number might need adjustment, make sure they have the correct order
  • The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

Release notes

Change Record

Translations

This was originally fixed by GraphQL module and it's available at version 4.7.0 but not yes updated on Open Social

see: drupal-graphql/graphql#1364
@tbsiqueira tbsiqueira added this to the 12.2.5 milestone Apr 11, 2024
Copy link

mergeable bot commented Apr 11, 2024

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

@tbsiqueira tbsiqueira changed the title Add patch to fix the serialization issue with GraphQL Issue #3440125 | Add patch to fix the serialization issue with GraphQL Apr 11, 2024
@tbsiqueira tbsiqueira added type: bug Fixes a bug in Open Social status: needs review This pull request is waiting for a requested review prio: critical team: iata labels Apr 11, 2024
@tbsiqueira
Copy link
Contributor Author

I'm closing this PR since version 4.7.0 is landing soon into the distro

@tbsiqueira tbsiqueira closed this Apr 11, 2024
@ronaldtebrake ronaldtebrake removed this from the 12.2.5 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: critical status: needs review This pull request is waiting for a requested review team: iata type: bug Fixes a bug in Open Social
2 participants