Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TBA: Fatal error on article edit page (Social Course) #3868

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nechai
Copy link
Contributor

@nechai nechai commented Apr 17, 2024

Problem

Solution

Issue tracker

Theme issue tracker

How to test

Definition of done

Before merge

  • Code/peer review is completed
  • All commit messages are clear and clean. If applicable a rebase was performed
  • All automated tests are green
  • Functional/manual tests of the acceptance criteria are approved
  • All acceptance criteria were met
  • New features or changes to existing features are covered by tests, either unit (preferably) or behat
  • Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
  • Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
  • This pull request has all required labels (team/type/priority)
  • This pull request has a milestone
  • This pull request has an assignee (if applicable)
  • Any front end changes are tested on all major browsers
  • New UI elements, or changes on UI elements are approved by the design team
  • New features, or feature changes are approved by the product owner

After merge

  • Code is tested on all branches that it has been cherry-picked
  • Update hook number might need adjustment, make sure they have the correct order
  • The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

Release notes

Change Record

Translations

@nechai nechai self-assigned this Apr 17, 2024
Copy link

mergeable bot commented Apr 17, 2024

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

@nechai nechai added type: bug Fixes a bug in Open Social and removed blocked: mergeable labels Apr 17, 2024
@mergeable mergeable bot added blocked: mergeable and removed type: bug Fixes a bug in Open Social labels Apr 17, 2024
Copy link

github-actions bot commented Apr 30, 2024

Thanks for opening this Pull Request! To ensure Pull Requests are easy to find and understand for all our team-members we've established some standardised rules. While reviewing this pull request I've found the following issues, please resolve them.

Missing type label
The pull request is missing a type: label to indicate whether the pull request is trying fix a bug, introduce a new feature or do something else.

Missing milestone
The issue is missing a milestone. Milestones are important to help release managers know whether they might need to postpone a release for a critical issue and to communicate what fixes and new features are included in a release. Before merging, please select the appropriate milestone for this pull request.

Invalid Title
The title you've provided for this pull request does not follow the expected title formats. Consistent titles make origins and purposes of issues easy to understand. Please use one of the following title formats:

  • PROD-NNN: for a PR related to an Open Social Jira issue
  • Issue #NNN: for a PR originating from a Drupal.org issue.
  • Internal: for a repository maintenance PR without matching Jira ticket (prefer creating a ticket to track your work).
  • Updates: for a PR that updates modules (e.g. by dependabot).
  • Hotfix: in case it's really important something gets fixed now.

Choose the proper prefix and write a title that tells developers without other context what your PR is about. Do NOT end your title with a period.

🤖 This is an automatically produced message by the Open Social PR manager.

@ribel ribel added team: enterprise This PR originates from the ECI team status: needs work This pull request needs more work before it's ready for review prio: low labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: low status: needs work This pull request needs more work before it's ready for review team: enterprise This PR originates from the ECI team
3 participants