Internal: Add Configuration to influence the order of branding features #3874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Right now we don't have an easy way to influence the bottom bar features, while we do promise that.
This was done by implementing a patch, per environment which uses
But than changing that per environment.
Solution
We now provide a new admin form, currently no permissions are set, as it's for now Admin only (until we know every business requirement we need to provide it for SM, e.g. which preferred features are available, mandatory, how many etc)
So this form gives admins a way to deal with the bottom bar features for the App.
Right now we use the existing hook as input for the ConfigForm which preferred features are available.
We add a draggable table to the form, which shows all available features.
And we change the place where the hook is invoked, for GraphQl, to the configuration from the form submitted.
Notes
hook_social_branding_preferred_features()
are available and usedIssue tracker
https://getopensocial.atlassian.net/browse/PROD-28762
https://www.drupal.org/project/social/issues/3442499
How to test
social_branding
, see that it works (unit tests also provide this proof)admin/config/opensocial/branding-features
Screenshots
Release notes
We have added an Admin form for the Branding features which are used through GraphQL.