Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3445552: Metatag for some Groups tab is not loading #3891

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

vcsvinicius
Copy link
Contributor

@vcsvinicius vcsvinicius commented May 6, 2024

Problem

The Metatage is not loading for some tabs on Group pages, because it, the preview is not loading when the link is shared on social media.

Solution

Added missing routes-name to add group entity at group pages.

Issue tracker

PROD-19200
#3445552

Theme issue tracker

N/A

How to test

Group

  • Enable Social Metatag
  • Create a group
  • Go to Stream tab and check the metatag

Twitter

  • Enable Social Metatag
  • Create a page, topic or event
  • Go to the new content and check twitter metatag

Screenshots

N/A

Release notes

The Stream tab will start to show preview about group when they are shared on Social Media.

Twitter will comeback to show preview from our pages

Change Record

N/A

Translations

N/A

@vcsvinicius vcsvinicius added type: bug Fixes a bug in Open Social status: needs review This pull request is waiting for a requested review prio: medium team: guardians labels May 6, 2024
@vcsvinicius vcsvinicius added this to the 12.3.5 milestone May 6, 2024
@vcsvinicius vcsvinicius requested a review from a team May 6, 2024 19:46
@vcsvinicius vcsvinicius force-pushed the bugfix/3445552/metatag-is-not-loading-in-some-tabs-on-groups branch from 94518ac to 442b9d3 Compare May 8, 2024 11:48
@vcsvinicius vcsvinicius modified the milestones: 12.3.5, 13.0.0-alpha2 May 8, 2024
@vcsvinicius vcsvinicius force-pushed the bugfix/3445552/metatag-is-not-loading-in-some-tabs-on-groups branch from 9c8a36b to 985f206 Compare May 8, 2024 14:41
@vcsvinicius vcsvinicius force-pushed the bugfix/3445552/metatag-is-not-loading-in-some-tabs-on-groups branch from 258701e to f71da9a Compare May 8, 2024 18:42
@robertragas
Copy link
Contributor

@vcsvinicius

I believe we don't need that many twitter tags as twitter(x) also use OG tags. See https://developer.twitter.com/en/docs/twitter-for-websites/cards/guides/getting-started#:~:text=The%20card%20type%2C%20which%20will,in%20sequence%20will%20take%20priority.
They even say there you can remove those to avoid duplication. Which means we only need to add the "card type" metatag.

@open-social-tugboat
Copy link

Tugboat has finished building the preview for this pull request!

Link:

Dashboard:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: medium status: needs review This pull request is waiting for a requested review team: guardians type: bug Fixes a bug in Open Social
4 participants