Issue #3445775: validateEntityFields is not correctly transforming date #3892
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanvidmar
added
type: bug
zanvidmar
added
type: test
…te field values. validateEntityFields() is not correctly transforming date field values for datetime type "date" fields (it works as designed for "datetime" type only). To fix the issue correct date format is applied for date only fields.
zanvidmar
force-pushed
the
issue/PROD-29315-behat-test-date-validation
branch
from
87b36e8
to
918186f
Compare
ronaldtebrake
modified the milestones:
13.0.0-alpha2,
13.0.0-alpha3,
13.0.0-alpha4,
13.0.0-alpha5
|
Tugboat has finished building the preview for this pull request! Link: Dashboard: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
validateEntityFields() is not correctly transforming date field values for datetime type "date" fields (it works as designed for "datetime" type only). To fix the issue correct date format is applied for date only fields.
Solution
Issue tracker
3445775 (PROD-29315)
Theme issue tracker
N/A
How to test
Create behat test step, that uses validateEntityFields method and validate date only field.
Created entity will have empty date field as an result of wrong date format applied.
With this fix applied date field will be correctly transformed.
Screenshots
N/A
Release notes
Improve tests.
Change Record
N/A
Translations
N/A