Issue #3445902: Apply static caching to the SocialPrivateMessageService #3893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramtenhove
added
status: needs review
bramtenhove
commented
May 8, 2024
| $user_storage = $this->userManager; | ||
| /** @var \Drupal\user\UserInterface $user */ | ||
| $user = $user_storage->load($uid); | ||
| if (!isset($unread)) { |
There was a problem hiding this comment.
This is the only actual change together with line 66, the rest is indentation.
…ateMessageService
bramtenhove
force-pushed
the
issue/private-message-static-caching
branch
from
fc0858c
to
4af1edc
Compare
ribel
approved these changes
May 8, 2024
bramtenhove
added
the
backport: verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
updateUnreadCount()function inSocialPrivateMessageServiceis sometimes called multiple times during a request.Solution
Apply simple static caching.
Issue tracker
https://www.drupal.org/project/social/issues/3445902
Theme issue tracker
N/a
How to test
Screenshots
N/a
Release notes
Minor performance improvement for the private message feature.
Change Record
N/a
Translations
N/a