Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3444592 - Revert removal of administer taxonomy permission for SM. #3903

Merged
merged 1 commit into from
May 22, 2024

Conversation

ronaldtebrake
Copy link
Contributor

@ronaldtebrake ronaldtebrake commented May 22, 2024

Problem

In #3885 we removed the administer taxonomy permission for SM.
This had some unwanted side effects.
Considering it already has been released we do it in another update hook to be kind to the community who are apparantly already using it. (From historical purposes probably also a good reference)

After fixing all the occurrences (like nationality / report reason) of taxonomy creation in the individual modules we can revoke this permission in the product again.

Solution

For now the PR #3885 still is fine, the added permissions aren't a problem, it's the removal of the administer taxonomy and us forgetting some of the vocabularies that we're relying on this permission for SM to be able to CRUD the terms in there.

Once we have fixed all the individual vocabulary & term permissions for SM we can revoke this permission.

Issue tracker

#3444592: Replace permission administer taxonomy with access taxonomy overview for SM

How to test

  • As a sitemanager
  • You should be able to manage the nationality list when social_profile_extra is Enabled

Release notes

None, removed the linked issue from release notes as we partially reverted this.

This had some unwanted side effects.
Considering it already has been released we do it in another update hook.
After fixing all the occurrences (like nationality / report reason) of taxonomy creation in the individual modules
we can revoke this permission in the product again.
@ronaldtebrake ronaldtebrake added type: bug Fixes a bug in Open Social status: needs review This pull request is waiting for a requested review prio: critical team: guardians labels May 22, 2024
@ronaldtebrake ronaldtebrake added this to the 13.0.0-alpha3 milestone May 22, 2024
Copy link

github-actions bot commented May 22, 2024

Thanks for opening this Pull Request! To ensure Pull Requests are easy to find and understand for all our team-members we've established some standardised rules. While reviewing this pull request I've found the following issues, please resolve them.

Invalid Title
The title you've provided for this pull request does not follow the expected title formats. Consistent titles make origins and purposes of issues easy to understand. Please use one of the following title formats:

  • PROD-NNN: for a PR related to an Open Social Jira issue
  • Issue #NNN: for a PR originating from a Drupal.org issue.
  • Internal: for a repository maintenance PR without matching Jira ticket (prefer creating a ticket to track your work).
  • Updates: for a PR that updates modules (e.g. by dependabot).
  • Hotfix: in case it's really important something gets fixed now.

Choose the proper prefix and write a title that tells developers without other context what your PR is about. Do NOT end your title with a period.

🤖 This is an automatically produced message by the Open Social PR manager.

@robertragas robertragas self-requested a review May 22, 2024 13:23
@ronaldtebrake ronaldtebrake merged commit 37475d3 into main May 22, 2024
193 of 194 checks passed
@ronaldtebrake ronaldtebrake deleted the issue/3444592-revert-administer-taxonomy branch May 22, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: critical status: needs review This pull request is waiting for a requested review team: guardians type: bug Fixes a bug in Open Social
2 participants