Issue #3444592 - Revert removal of administer taxonomy permission for SM. #3903
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In #3885 we removed the administer taxonomy permission for SM.
This had some unwanted side effects.
Considering it already has been released we do it in another update hook to be kind to the community who are apparantly already using it. (From historical purposes probably also a good reference)
After fixing all the occurrences (like nationality / report reason) of taxonomy creation in the individual modules we can revoke this permission in the product again.
Solution
For now the PR #3885 still is fine, the added permissions aren't a problem, it's the removal of the administer taxonomy and us forgetting some of the vocabularies that we're relying on this permission for SM to be able to CRUD the terms in there.
Once we have fixed all the individual vocabulary & term permissions for SM we can revoke this permission.
Issue tracker
#3444592: Replace permission administer taxonomy with access taxonomy overview for SM
How to test
social_profile_extra
is EnabledRelease notes
None, removed the linked issue from release notes as we partially reverted this.