Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #3454115: Deny access to unpublished events for enrolled users #3926

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Issue #3454115: Deny access to unpublished events for enrolled users #3926

merged 1 commit into from
Jun 14, 2024

Conversation

Macsym2018
Copy link

@Macsym2018 Macsym2018 commented Jun 12, 2024 •
edited by ribel
Loading

Problem

Unpublished events are visible to enrolled VU via URL.

Solution

Add check for enrolled users if the event is published or not.

Issue tracker

Theme issue tracker

N/A

How to test

  • Create an event
  • Enroll user to this event
  • Unpublish this event
  • Go the event via the direct URL

Screenshots

N/A

Release notes

User should not be able to access an unpublished event even if he is enrolled in it.

Change Record

N/A

Translations

N/A

@Macsym2018 Macsym2018 requested a review from ribel June 12, 2024 10:45
@Macsym2018 Macsym2018 added team: enterprise This PR originates from the ECI team status: needs review This pull request is waiting for a requested review labels Jun 12, 2024
@Macsym2018 Macsym2018 added this to the 13.0.0-alpha5 milestone Jun 12, 2024
@ribel ribel changed the title issue #3454115: Deny access to enrolled events for VU Issue #3454115: Deny access to enrolled events for VU Jun 12, 2024
@Macsym2018 Macsym2018 force-pushed the 3454115-unpublished-event-access branch 2 times, most recently from b5ae932 to 76be4d5 Compare June 12, 2024 14:45
@Macsym2018 Macsym2018 added prio: high type: bug Fixes a bug in Open Social labels Jun 12, 2024
@ribel ribel force-pushed the 3454115-unpublished-event-access branch from 76be4d5 to 9158736 Compare June 14, 2024 07:49
@Macsym2018 Macsym2018 force-pushed the 3454115-unpublished-event-access branch from 9158736 to fde779c Compare June 14, 2024 13:08
ribel
ribel approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@ribel ribel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes were tested and work as expected now.

@ribel ribel changed the title Issue #3454115: Deny access to enrolled events for VU Issue #3454115: Deny access to unpublished events for enrolled users Jun 14, 2024
@ribel ribel merged commit 58246e9 into main Jun 14, 2024
189 checks passed
@ribel ribel deleted the 3454115-unpublished-event-access branch June 14, 2024 16:08
@ribel ribel added backport: not needed This pull request only needs to land on main and does not need a backport and removed status: needs review This pull request is waiting for a requested review labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ribel ribel ribel approved these changes

Assignees
No one assigned
Labels
backport: not needed This pull request only needs to land on main and does not need a backport prio: high team: enterprise This PR originates from the ECI team type: bug Fixes a bug in Open Social
Milestone
13.0.0-alpha5
2 participants
@Macsym2018 @ribel