Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2890000 - When deleting a comment, also remove any attached files #469

Merged
merged 1 commit into from Jul 17, 2017
Merged

#2890000 - When deleting a comment, also remove any attached files #469

merged 1 commit into from Jul 17, 2017

Conversation

jochemvn
Copy link
Contributor

@jochemvn jochemvn commented Jul 11, 2017 •
edited by frankgraave

Description

For description see: https://www.drupal.org/node/2890000

HTT

  • Enable the social_comment_upload module
  • Notice that on topics/events you can now add attachments to comments
  • Add one or more attachments to a comment and save it
  • See them in the file_managed table
  • See that you can access the file from the URL (copy it from source)
  • See that when you log out you can no longer access the file through the URL (private file system)
  • Now delete the comment
  • Notice that the entry in the file_managed table is gone and you can no longer access the file from the URL anymore (as the comment creator)

@frankgraave frankgraave merged commit d618da3 into 8.x-1.x Jul 17, 2017
@frankgraave frankgraave deleted the feature/2890000-attachments-on-comments branch July 17, 2017 14:46
@jochemvn jochemvn added this to the 1.2 Release milestone Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankgraave frankgraave frankgraave approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
1.2 Release
2 participants
@jochemvn @frankgraave