New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DS-4122 - Move front-end libraries to composer.json #531
Conversation
…into feature/DS-4122-move-libraries
…t icon visible and make sure close button doesn't reset the form
…ustom composer packages
…eady defined somewhere else
…nto feature/DS-4122-search-script
…ocialbase.libraries.yml file
DS-4122 - Remove libraries and refactor search script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would still like to test it when updating from 1. to this version
I tested the update path for users by using the drupal_social repo. Due to all the PR's still open it is a little bit hard. I could not find a way to be able to run the script that updates the composer.json file for people. Not sure how to run it in the list below, any clue @jochemvn?
|
…k to get them from libraries folder
Description
This PR has a lot of changes, sorry for that. However we already split it up a little bit, see #519.
The idea is to remove all of the front-end libraries from the codebase and require them via a package manager. This means we removed a lot of code! And @MaikelGG rewrote the search script to make it work.
See also PR #530 and goalgorilla/drupal_social#320.
Important
Make sure you followed instructions at #530.
How to test
If goalgorilla/drupal_social#320 is merged, it makes it easier for you.
Please note that we did not really update any library versions, except for Waves. Morris and Raphael didn't change in version either and are only used by the analytics module, so hard to test. Now test the different libraries by: