Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-4122 - Move front-end libraries to composer.json #531

Merged
merged 47 commits into from Sep 22, 2017

Conversation

bramtenhove
Copy link
Member

@bramtenhove bramtenhove commented Sep 11, 2017

Description

This PR has a lot of changes, sorry for that. However we already split it up a little bit, see #519.

The idea is to remove all of the front-end libraries from the codebase and require them via a package manager. This means we removed a lot of code! And @MaikelGG rewrote the search script to make it work.

See also PR #530 and goalgorilla/drupal_social#320.

Important

Make sure you followed instructions at #530.

How to test

If goalgorilla/drupal_social#320 is merged, it makes it easier for you.

Please note that we did not really update any library versions, except for Waves. Morris and Raphael didn't change in version either and are only used by the analytics module, so hard to test. Now test the different libraries by:

  • Waves library by clicking on buttons (should cause a wave in the button)
  • Timepicker library by creating an event, you can pick the time via this tool
  • Click through the site for the Bootstrap library, create a group, join an event, check tabs on user profile page, etc.

bramtenhove and others added 30 commits August 30, 2017 12:36
…t icon visible and make sure close button doesn't reset the form
Copy link
Contributor

@jochemvn jochemvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would still like to test it when updating from 1. to this version

@bramtenhove
Copy link
Member Author

bramtenhove commented Sep 12, 2017

I tested the update path for users by using the drupal_social repo. Due to all the PR's still open it is a little bit hard. I could not find a way to be able to run the script that updates the composer.json file for people. Not sure how to run it in the list below, any clue @jochemvn?

  • Set-up the project: git clone git@github.com:goalgorilla/drupal_social.git test-dir; cd test-dir;
  • Now change line 13 in composer.json to "goalgorilla/open_social": "^1.0",, now using the stable build
  • Run composer install and install the site
  • Go to the test-dir again and change line 13 to "goalgorilla/open_social": "dev-feature/DS-4122-move-libraries",
  • Make the changes to the composer.json file, see https://github.com/goalgorilla/drupal_social/pull/320/files
  • Run composer update
  • Run drush updb -y, etc.
  • Check that the site works and that libraries are now in html/libraries

@bramtenhove bramtenhove added this to the 1.5 Release milestone Sep 22, 2017
@bramtenhove bramtenhove merged commit 1c65b65 into 8.x-1.x Sep 22, 2017
@bramtenhove bramtenhove deleted the feature/DS-4122-move-libraries branch September 22, 2017 09:58
nechai added a commit that referenced this pull request Apr 5, 2023
)

PROD-23421: Event passing date respect user timezone

Approved-by: Taras Kruts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants