Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2912755 - Enable inline form errors module and add styling #578

Merged
merged 15 commits into from Oct 13, 2017

Conversation

jochemvn
Copy link
Contributor

@jochemvn jochemvn commented Oct 12, 2017

Description

Inline form errors will be stable in release 8.4. Let's add support for it in the social themes. This will make the overal experience a lot better.

Drupal

https://www.drupal.org/node/2912755

HTT

  • login as admin and Go to extend and enable inline form errors module
  • login as a normal user
  • Go to Add Event form and submit an empty form. You should see well themed inline form errors which are dismissible alerts. Also on top you see a message with links. The links should be bring you to the correct field.
  • Go to edit your profile and leave all fields blank and submit the form. Look at the form feedback and inline form error placement.

Note: The module is not turned on by default. The order of errors in the message is not in the correct order. This is not part of this story.

@jochemvn
Copy link
Contributor Author

@MaikelGG, please add some test steps.

If the tests are green you can merge

@MaikelGG MaikelGG assigned bramtenhove and unassigned bramtenhove Oct 12, 2017
@MaikelGG MaikelGG merged commit 1991c61 into 8.x-1.x Oct 13, 2017
@MaikelGG MaikelGG deleted the feature/2912755-inline-form-errors branch October 13, 2017 09:13
@jochemvn jochemvn added this to the 1.6 Release milestone Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants