#2944419 - Hero images for custom content types when machine name is too long

[jaapjan]

This is a copy of the original pullrequest #727 and the issue can be found here: https://www.drupal.org/project/social/issues/2944419

Problem

If you use a custom content type (not provided by Open Social) and happens to have a long name, the validation above will fail because machine names can only be 26 characters long.
In order to at least have the possibility of having an image set, new code needs to load an image field as hero, as long as it has the word "image" on its field name and it is an image field.

Solution

I've written code to handle this special case

Issue tracker

Created the issue directly on GitHub

HTT

• Check out the code changes
• Login as user admin and create a content type with a "long" name (21 chars or more), then assign an image field following convention " image" so machine name would be field_<content_type_name>_image, create a new node based on that content type including uploading an image.
• Notice it doesn't work, hero image won't load
• Checkout to this branch
• On the content type you just created, if you add an image field that has the word "image" in its machine name (you can even re-use one of the image fields established for the default content types) and is an image field, the hero image will load.

Documentation

• This item is added to the release notes
• This item is documented on LGOS
• This item has been added to the feature overview