Add assertions to Aspect loader extensions to restrict types of refle…

…ction items
goaop · Jan 6, 2021 · 271dcd6 · 271dcd6
1 parent ef1358d
commit 271dcd6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/Core/GeneralAspectLoaderExtension.php b/src/Core/GeneralAspectLoaderExtension.php
@@ -76,7 +76,7 @@ public function supports(Aspect $aspect, $reflection, $metaInformation = null):
      * Loads definition from specific point of aspect into the container
      *
      * @param Aspect $aspect Instance of aspect
-     * @param Reflector|ReflectionMethod $reflection Reflection of point
+     * @param Reflector $reflection Reflection of point
      * @param mixed|null $metaInformation Additional meta-information, e.g. annotation for method
      *
      * @return array|Pointcut[]|Advisor[]
@@ -85,6 +85,7 @@ public function supports(Aspect $aspect, $reflection, $metaInformation = null):
      */
     public function load(Aspect $aspect, Reflector $reflection, $metaInformation = null): array
     {
+        assert($reflection instanceof ReflectionMethod, 'Only ReflectionMethod is expected here');
         $loadedItems    = [];
         $pointcut       = $this->parsePointcut($aspect, $reflection, $metaInformation->value);
         $methodId       = get_class($aspect) . '->' . $reflection->name;

diff --git a/src/Core/IntroductionAspectExtension.php b/src/Core/IntroductionAspectExtension.php
@@ -71,15 +71,16 @@ public function supports(Aspect $aspect, $reflection, $metaInformation = null):
      * Loads definition from specific point of aspect into the container
      *
      * @param Aspect $aspect Instance of aspect
-     * @param Reflector|ReflectionProperty $reflection Reflection of point
+     * @param Reflector $reflection Reflection of point
      * @param mixed|null $metaInformation Additional meta-information
      *
      * @throws UnexpectedValueException
      *
      * @return Pointcut[]|Advisor[]
      */
-    public function load(Aspect $aspect, $reflection, $metaInformation = null): array
+    public function load(Aspect $aspect, Reflector $reflection, $metaInformation = null): array
     {
+        assert($reflection instanceof ReflectionProperty, 'Only ReflectionProperty is expected here');
         $loadedItems = [];
         $pointcut    = $this->parsePointcut($aspect, $reflection, $metaInformation->value);
         $propertyId  = $reflection->class . '->' . $reflection->name;