Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error with "self" references in top level ns #397

Merged
merged 2 commits into from
Jun 8, 2018

Conversation

daniel-sc
Copy link
Contributor

This fixes an error when a class with top level namespace uses self:: to reference a class constant.

The error manifests for example as:

PHP Parse error:  syntax error, unexpected '\' (T_NS_SEPARATOR), expecting identifier (T_STRING)

.gitignore Outdated
@@ -3,3 +3,4 @@ composer.lock
phpunit.xml
tests/Fixtures/project/var/cache/*
build/
.idea
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go to your global gitignore.

See, per example, this: https://gist.github.com/subfuzion/db7f57fff2fb6998a16c but you can find a loot of resources on this topic.

Point here is - rules for ignoring IDE specific files (or system specific files) should not be part of .gitignore files, as we could get into a really large .gitignore files.

Copy link
Contributor

@TheCelavi TheCelavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert .gitignore file.

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@daniel-sc
Copy link
Contributor Author

Hi @TheCelavi,
I reverted the .gitignore, but for unclear reasons the AppVeyor build fails no (was working before) - could you maybe restart the build?

@lisachenko
Copy link
Member

AppVeyor is buggy and crappy, so we could ignore this fail.

@lisachenko
Copy link
Member

I think it would be nice to target 2.x branch, because master is not ready yet, so small patch could be released from 2.x

@lisachenko lisachenko changed the base branch from master to 2.x June 8, 2018 14:27
@daniel-sc
Copy link
Contributor Author

@lisachenko 2.x and a new release would be perfect!
Can you merge, or do you need any thing else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants