-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix error with "self" references in top level ns #397
Conversation
.gitignore
Outdated
@@ -3,3 +3,4 @@ composer.lock | |||
phpunit.xml | |||
tests/Fixtures/project/var/cache/* | |||
build/ | |||
.idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go to your global gitignore.
See, per example, this: https://gist.github.com/subfuzion/db7f57fff2fb6998a16c but you can find a loot of resources on this topic.
Point here is - rules for ignoring IDE specific files (or system specific files) should not be part of .gitignore files, as we could get into a really large .gitignore files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert .gitignore file.
The inspection completed: No new issues |
Hi @TheCelavi, |
AppVeyor is buggy and crappy, so we could ignore this fail. |
I think it would be nice to target 2.x branch, because master is not ready yet, so small patch could be released from 2.x |
@lisachenko |
This fixes an error when a class with top level namespace uses
self::
to reference a class constant.The error manifests for example as: