Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Change from white/black to a more inclusive language (allow/block?) #182

Closed
1 of 2 tasks
caiangums opened this issue Jun 18, 2021 · 3 comments
Closed
1 of 2 tasks
Labels
wontfix This will not be worked on

Comments

@caiangums
Copy link
Contributor

caiangums commented Jun 18, 2021

Thanks for all the work on this library and for making it robust!

Proposal

This issue is being opened as a suggestion to move in a more inclusive terminology, removing the white/black reference and changing it to the allow/block reference (names are just a suggestion).

Impacts and Legacy usage

Understanding legacy projects that are not being maintained and those that can schedule a change to their projects, the suggestion is to inform about the deprecation with a warning while using those terms and already accept the new ones. Thinking about this, there are 2 PRs opened:

The first one is not a breaking change, so it is possible to be merged and deployed as the old terms are still supported. The second one could be merged in the future version as it is a breaking change (new major version? 🤔)

Reference

As one of many references for this change, Rails community already changed it with the small difference between block for deny.

@goatandsheep
Copy link
Owner

goatandsheep commented Jun 25, 2021

that's pretty awesome actually. I like the first one better actually. The second would be a breaking change.

@caiangums
Copy link
Contributor Author

caiangums commented Jun 25, 2021

The idea behind the second PR is exactly a breaking change and possibly, be merged at a future release! 😄

Thanks for accepting! 🙏

@stale
Copy link

stale bot commented Aug 25, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 25, 2021
@stale stale bot closed this as completed Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants