Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP_ENV breaks builds that already use that environment variable #219

Closed
2 tasks done
bfricka opened this issue Aug 26, 2021 · 10 comments
Closed
2 tasks done

APP_ENV breaks builds that already use that environment variable #219

bfricka opened this issue Aug 26, 2021 · 10 comments
Assignees

Comments

@bfricka
Copy link
Contributor

bfricka commented Aug 26, 2021

  • Tried the troubleshooting Wiki
  • Followed the migration Wiki

Describe the bug
The title basically says it. The addition of the APP_ENV override is a breaking change for those of us who already had that variable defined for other purposes.

Expected behavior
I should have a way of overriding this variable if I don't want to use it or want to use another variable.

I've already created a fix for this, so I'm opening this issue because the template wanted me to do so before opening a PR.

@github-actions
Copy link

Hey, thank you for opening this issue! 🙂 To boost priority on this issue and support open source please tip the team at https://issuehunt.io/r/goatandsheep/react-native-dotenv/issues/219

@bfricka
Copy link
Contributor Author

bfricka commented Aug 31, 2021

Hello there! It's been several days since I opened this, and I think it's a pretty straightforward issue and PR. Anything I can do to help this move forward? Thank you.

@goatandsheep
Copy link
Owner

sorry! I was AFK for a few months. I will be reviewing it and probably merging it within the next week

@bfricka
Copy link
Contributor Author

bfricka commented Nov 2, 2021

Baaaahh

@goatandsheep
Copy link
Owner

okay I'm checking it now!!

@goatandsheep
Copy link
Owner

To be honest, I think APP_ENV should still be used even if you're already using it. It's better to be consistent with a standard. However, I won't be surprised if you're not the only one who wants this. I want to continue to label it as an experimental feature available as a backup in the README

@goatandsheep
Copy link
Owner

if you're okay with that, I'll merge the changes in, add the "fix", then tag you and if you're okay with that, I'll release the next version?

@goatandsheep
Copy link
Owner

I'll do release tomorrow

@bfricka
Copy link
Contributor Author

bfricka commented Nov 2, 2021

In our case, we can't use APP_ENV because the enum that we use has different values from those accepted by dotenv. At some point I might refactor this to use something else, but it's pretty consistent across our projects. I'm fine with however you want to release. Thanks.

@goatandsheep
Copy link
Owner

okay! with that, we can safely close this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants