Do not subtract MESSAGE_HEADER_LEN from version payload length #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cherry picked into master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The payload length does not include the MESSAGE_HEADER_LEN which means that our calculation for the remaining size of the version payload is too small. When the payload length is exactly 104 bytes (as it is with Bitcoin Core 0.15.0.1 due to the slightly longer user agent), this will cause
get_varintto fail. This was not experienced before because the version message was 2 bytes shorter at 102 bytes so the size remaining was greater than 0.This should fix the bug identified by @jameshilliard on IRC.