[WIP] Overhaul macOS build process #403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Completely change the macOS build process. No external libraries outside of the cppForSwig subdirectory are now built. Users will have to rely on brew and pip in order to install certain required third-party libraries. - Fix up the notes as required. The idea is to make macOS compilation more like Linux compilation and remove the need to maintain/modify third-party libraries. This will also make it far easier to transition Armory from Python 2 to Python 3, Qt 4 to Qt 5, etc., along with making deterministic builds far easier to obtain down the road. This is a work-in-progress. Objective-C code isn't compiled (and related code is commented out of the Python code), the notes need to be finalized and checked against a fresh macOS VM, Armory needs to be run for awhile to see if it's stable, etc.
|
As mentioned in the original commit message, this is a work-in-progress. I also need to mod ArmoryQt.py to be in line with what was in the repo. (I yanked the file from a different repo by accident.) This PR can be ignored for now. I'll report back when the PR's ready for review. |
Kick off Armory using standard Python, not an Armory-built Python.
- Make macOS build script Python3-compatible. - Adjust the Mac notes to better reflect what users should expect. (Subject to change.) - To make future merges easier, sync Mac READMEs with the mainline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to make macOS compilation more like Linux compilation and remove the need to maintain/modify third-party libraries. This will also make it far easier to transition Armory from Python 2 to Python 3, Qt 4 to Qt 5, etc., along with making deterministic builds far easier to obtain down the road.
This is a work-in-progress. Objective-C code isn't compiled (and related code is commented out of the Python code), the notes need to be finalized and checked against a fresh macOS VM, Armory needs to be run for awhile to see if it's stable, etc.