Skip to content

Commit

Permalink
Fix lint and coverage
Browse files Browse the repository at this point in the history
  • Loading branch information
@goatslacker
goatslacker committed Apr 11, 2015
1 parent b755627 commit 5dac8e8
Show file tree
Hide file tree
Showing 6 changed files with 111 additions and 82 deletions.
40 changes: 23 additions & 17 deletions dist/alt-browser-with-addons.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1042,7 +1042,7 @@ function NoopClass() {}
var builtIns = Object.getOwnPropertyNames(NoopClass);
var builtInProto = Object.getOwnPropertyNames(NoopClass.prototype);

var getInternalMethods = function (obj, excluded) {
function getInternalMethods(obj, excluded) {
return Object.getOwnPropertyNames(obj).reduce(function (value, m) {
if (excluded.indexOf(m) !== -1) {
return value;
Expand All @@ -1051,7 +1051,7 @@ var getInternalMethods = function (obj, excluded) {
value[m] = obj[m];
return value;
}, {});
};
}

var AltStore = (function () {
function AltStore(dispatcher, model, state, StoreModel) {
Expand Down Expand Up @@ -1260,7 +1260,7 @@ var StoreMixinEssentials = {
}
};

var setAppState = function (instance, data, onStore) {
function setAppState(instance, data, onStore) {
var obj = instance.deserialize(data);
Object.keys(obj).forEach(function (key) {
var store = instance.stores[key];
Expand All @@ -1272,9 +1272,9 @@ var setAppState = function (instance, data, onStore) {
onStore(store);
}
});
};
}

var snapshot = function (instance) {
function snapshot(instance) {
for (var _len = arguments.length, storeNames = Array(_len > 1 ? _len - 1 : 0), _key = 1; _key < _len; _key++) {
storeNames[_key - 1] = arguments[_key];
}
Expand All @@ -1289,17 +1289,17 @@ var snapshot = function (instance) {
obj[key] = customSnapshot ? customSnapshot : store.getState();
return obj;
}, {});
};
}

var saveInitialSnapshot = function (instance, key) {
function saveInitialSnapshot(instance, key) {
var state = instance.stores[key][STATE_CONTAINER];
var initial = instance.deserialize(instance[INIT_SNAPSHOT]);
initial[key] = state;
instance[INIT_SNAPSHOT] = instance.serialize(initial);
instance[LAST_SNAPSHOT] = instance[INIT_SNAPSHOT];
};
}

var filterSnapshotOfStores = function (instance, serializedSnapshot, storeNames) {
function filterSnapshotOfStores(instance, serializedSnapshot, storeNames) {
var stores = instance.deserialize(serializedSnapshot);
var storesToReset = storeNames.reduce(function (obj, name) {
if (!stores[name]) {
Expand All @@ -1309,7 +1309,7 @@ var filterSnapshotOfStores = function (instance, serializedSnapshot, storeNames)
return obj;
}, {});
return instance.serialize(storesToReset);
};
}

function createStoreFromObject(alt, StoreModel, key) {
var storeInstance = undefined;
Expand Down Expand Up @@ -1356,8 +1356,8 @@ function createStoreFromObject(alt, StoreModel, key) {
}

function createStoreFromClass(alt, StoreModel, key) {
for (var _len = arguments.length, args = Array(_len > 3 ? _len - 3 : 0), _key = 3; _key < _len; _key++) {
args[_key - 3] = arguments[_key];
for (var _len = arguments.length, argsForConstructor = Array(_len > 3 ? _len - 3 : 0), _key = 3; _key < _len; _key++) {
argsForConstructor[_key - 3] = arguments[_key];
}

var storeInstance = undefined;
Expand Down Expand Up @@ -1403,7 +1403,7 @@ function createStoreFromClass(alt, StoreModel, key) {
Store.prototype[LISTENERS] = {};
Store.prototype[PUBLIC_METHODS] = {};

var store = _applyConstructor(Store, args);
var store = _applyConstructor(Store, argsForConstructor);

storeInstance = assign(new AltStore(alt.dispatcher, store, null, StoreModel), getInternalMethods(StoreModel, builtIns));

Expand Down Expand Up @@ -1509,8 +1509,8 @@ var Alt = (function () {
value: function createActions(ActionsClass) {
var _this8 = this;

for (var _len = arguments.length, args = Array(_len > 2 ? _len - 2 : 0), _key = 2; _key < _len; _key++) {
args[_key - 2] = arguments[_key];
for (var _len = arguments.length, argsForConstructor = Array(_len > 2 ? _len - 2 : 0), _key = 2; _key < _len; _key++) {
argsForConstructor[_key - 2] = arguments[_key];
}

var exportObj = arguments[1] === undefined ? {} : arguments[1];
Expand Down Expand Up @@ -1559,7 +1559,7 @@ var Alt = (function () {
return ActionsGenerator;
})(ActionsClass);

_applyConstructor(ActionsGenerator, args);
_applyConstructor(ActionsGenerator, argsForConstructor);
})();
} else {
assign(actions, ActionsClass);
Expand Down Expand Up @@ -1632,7 +1632,13 @@ var Alt = (function () {
// Instance type methods for injecting alt into your application as context

value: function addActions(name, ActionsClass) {
this.actions[name] = Array.isArray(ActionsClass) ? this.generateActions.apply(this, ActionsClass) : this.createActions(ActionsClass);
var _ref;

for (var _len = arguments.length, args = Array(_len > 2 ? _len - 2 : 0), _key = 2; _key < _len; _key++) {
args[_key - 2] = arguments[_key];
}

this.actions[name] = Array.isArray(ActionsClass) ? this.generateActions.apply(this, ActionsClass) : (_ref = this).createActions.apply(_ref, [ActionsClass].concat(args));
}
},
addStore: {
Expand Down
40 changes: 23 additions & 17 deletions dist/alt-browser.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -786,7 +786,7 @@ function NoopClass() {}
var builtIns = Object.getOwnPropertyNames(NoopClass);
var builtInProto = Object.getOwnPropertyNames(NoopClass.prototype);

var getInternalMethods = function (obj, excluded) {
function getInternalMethods(obj, excluded) {
return Object.getOwnPropertyNames(obj).reduce(function (value, m) {
if (excluded.indexOf(m) !== -1) {
return value;
Expand All @@ -795,7 +795,7 @@ var getInternalMethods = function (obj, excluded) {
value[m] = obj[m];
return value;
}, {});
};
}

var AltStore = (function () {
function AltStore(dispatcher, model, state, StoreModel) {
Expand Down Expand Up @@ -1004,7 +1004,7 @@ var StoreMixinEssentials = {
}
};

var setAppState = function (instance, data, onStore) {
function setAppState(instance, data, onStore) {
var obj = instance.deserialize(data);
Object.keys(obj).forEach(function (key) {
var store = instance.stores[key];
Expand All @@ -1016,9 +1016,9 @@ var setAppState = function (instance, data, onStore) {
onStore(store);
}
});
};
}

var snapshot = function (instance) {
function snapshot(instance) {
for (var _len = arguments.length, storeNames = Array(_len > 1 ? _len - 1 : 0), _key = 1; _key < _len; _key++) {
storeNames[_key - 1] = arguments[_key];
}
Expand All @@ -1033,17 +1033,17 @@ var snapshot = function (instance) {
obj[key] = customSnapshot ? customSnapshot : store.getState();
return obj;
}, {});
};
}

var saveInitialSnapshot = function (instance, key) {
function saveInitialSnapshot(instance, key) {
var state = instance.stores[key][STATE_CONTAINER];
var initial = instance.deserialize(instance[INIT_SNAPSHOT]);
initial[key] = state;
instance[INIT_SNAPSHOT] = instance.serialize(initial);
instance[LAST_SNAPSHOT] = instance[INIT_SNAPSHOT];
};
}

var filterSnapshotOfStores = function (instance, serializedSnapshot, storeNames) {
function filterSnapshotOfStores(instance, serializedSnapshot, storeNames) {
var stores = instance.deserialize(serializedSnapshot);
var storesToReset = storeNames.reduce(function (obj, name) {
if (!stores[name]) {
Expand All @@ -1053,7 +1053,7 @@ var filterSnapshotOfStores = function (instance, serializedSnapshot, storeNames)
return obj;
}, {});
return instance.serialize(storesToReset);
};
}

function createStoreFromObject(alt, StoreModel, key) {
var storeInstance = undefined;
Expand Down Expand Up @@ -1100,8 +1100,8 @@ function createStoreFromObject(alt, StoreModel, key) {
}

function createStoreFromClass(alt, StoreModel, key) {
for (var _len = arguments.length, args = Array(_len > 3 ? _len - 3 : 0), _key = 3; _key < _len; _key++) {
args[_key - 3] = arguments[_key];
for (var _len = arguments.length, argsForConstructor = Array(_len > 3 ? _len - 3 : 0), _key = 3; _key < _len; _key++) {
argsForConstructor[_key - 3] = arguments[_key];
}

var storeInstance = undefined;
Expand Down Expand Up @@ -1147,7 +1147,7 @@ function createStoreFromClass(alt, StoreModel, key) {
Store.prototype[LISTENERS] = {};
Store.prototype[PUBLIC_METHODS] = {};

var store = _applyConstructor(Store, args);
var store = _applyConstructor(Store, argsForConstructor);

storeInstance = assign(new AltStore(alt.dispatcher, store, null, StoreModel), getInternalMethods(StoreModel, builtIns));

Expand Down Expand Up @@ -1253,8 +1253,8 @@ var Alt = (function () {
value: function createActions(ActionsClass) {
var _this8 = this;

for (var _len = arguments.length, args = Array(_len > 2 ? _len - 2 : 0), _key = 2; _key < _len; _key++) {
args[_key - 2] = arguments[_key];
for (var _len = arguments.length, argsForConstructor = Array(_len > 2 ? _len - 2 : 0), _key = 2; _key < _len; _key++) {
argsForConstructor[_key - 2] = arguments[_key];
}

var exportObj = arguments[1] === undefined ? {} : arguments[1];
Expand Down Expand Up @@ -1303,7 +1303,7 @@ var Alt = (function () {
return ActionsGenerator;
})(ActionsClass);

_applyConstructor(ActionsGenerator, args);
_applyConstructor(ActionsGenerator, argsForConstructor);
})();
} else {
assign(actions, ActionsClass);
Expand Down Expand Up @@ -1376,7 +1376,13 @@ var Alt = (function () {
// Instance type methods for injecting alt into your application as context

value: function addActions(name, ActionsClass) {
this.actions[name] = Array.isArray(ActionsClass) ? this.generateActions.apply(this, ActionsClass) : this.createActions(ActionsClass);
var _ref;

for (var _len = arguments.length, args = Array(_len > 2 ? _len - 2 : 0), _key = 2; _key < _len; _key++) {
args[_key - 2] = arguments[_key];
}

this.actions[name] = Array.isArray(ActionsClass) ? this.generateActions.apply(this, ActionsClass) : (_ref = this).createActions.apply(_ref, [ActionsClass].concat(args));
}
},
addStore: {
Expand Down
38 changes: 21 additions & 17 deletions dist/alt-with-runtime.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ function NoopClass() {}
var builtIns = Object.getOwnPropertyNames(NoopClass);
var builtInProto = Object.getOwnPropertyNames(NoopClass.prototype);

var getInternalMethods = function (obj, excluded) {
function getInternalMethods(obj, excluded) {
return Object.getOwnPropertyNames(obj).reduce(function (value, m) {
if (excluded.indexOf(m) !== -1) {
return value;
Expand All @@ -50,7 +50,7 @@ var getInternalMethods = function (obj, excluded) {
value[m] = obj[m];
return value;
}, {});
};
}

var AltStore = (function () {
function AltStore(dispatcher, model, state, StoreModel) {
Expand Down Expand Up @@ -257,7 +257,7 @@ var StoreMixinEssentials = {
}
};

var setAppState = function (instance, data, onStore) {
function setAppState(instance, data, onStore) {
var obj = instance.deserialize(data);
Object.keys(obj).forEach(function (key) {
var store = instance.stores[key];
Expand All @@ -269,9 +269,9 @@ var setAppState = function (instance, data, onStore) {
onStore(store);
}
});
};
}

var snapshot = function (instance) {
function snapshot(instance) {
for (var _len = arguments.length, storeNames = Array(_len > 1 ? _len - 1 : 0), _key = 1; _key < _len; _key++) {
storeNames[_key - 1] = arguments[_key];
}
Expand All @@ -286,17 +286,17 @@ var snapshot = function (instance) {
obj[key] = customSnapshot ? customSnapshot : store.getState();
return obj;
}, {});
};
}

var saveInitialSnapshot = function (instance, key) {
function saveInitialSnapshot(instance, key) {
var state = instance.stores[key][STATE_CONTAINER];
var initial = instance.deserialize(instance[INIT_SNAPSHOT]);
initial[key] = state;
instance[INIT_SNAPSHOT] = instance.serialize(initial);
instance[LAST_SNAPSHOT] = instance[INIT_SNAPSHOT];
};
}

var filterSnapshotOfStores = function (instance, serializedSnapshot, storeNames) {
function filterSnapshotOfStores(instance, serializedSnapshot, storeNames) {
var stores = instance.deserialize(serializedSnapshot);
var storesToReset = storeNames.reduce(function (obj, name) {
if (!stores[name]) {
Expand All @@ -306,7 +306,7 @@ var filterSnapshotOfStores = function (instance, serializedSnapshot, storeNames)
return obj;
}, {});
return instance.serialize(storesToReset);
};
}

function createStoreFromObject(alt, StoreModel, key) {
var storeInstance = undefined;
Expand Down Expand Up @@ -353,8 +353,8 @@ function createStoreFromObject(alt, StoreModel, key) {
}

function createStoreFromClass(alt, StoreModel, key) {
for (var _len = arguments.length, args = Array(_len > 3 ? _len - 3 : 0), _key = 3; _key < _len; _key++) {
args[_key - 3] = arguments[_key];
for (var _len = arguments.length, argsForConstructor = Array(_len > 3 ? _len - 3 : 0), _key = 3; _key < _len; _key++) {
argsForConstructor[_key - 3] = arguments[_key];
}

var storeInstance = undefined;
Expand Down Expand Up @@ -399,7 +399,7 @@ function createStoreFromClass(alt, StoreModel, key) {
Store.prototype[LISTENERS] = {};
Store.prototype[PUBLIC_METHODS] = {};

var store = babelHelpers.applyConstructor(Store, args);
var store = babelHelpers.applyConstructor(Store, argsForConstructor);

storeInstance = assign(new AltStore(alt.dispatcher, store, null, StoreModel), getInternalMethods(StoreModel, builtIns));

Expand Down Expand Up @@ -502,8 +502,8 @@ var Alt = (function () {
value: function createActions(ActionsClass) {
var _this8 = this;

for (var _len = arguments.length, args = Array(_len > 2 ? _len - 2 : 0), _key = 2; _key < _len; _key++) {
args[_key - 2] = arguments[_key];
for (var _len = arguments.length, argsForConstructor = Array(_len > 2 ? _len - 2 : 0), _key = 2; _key < _len; _key++) {
argsForConstructor[_key - 2] = arguments[_key];
}

var exportObj = arguments[1] === undefined ? {} : arguments[1];
Expand Down Expand Up @@ -550,7 +550,7 @@ var Alt = (function () {
return ActionsGenerator;
})(ActionsClass);

babelHelpers.applyConstructor(ActionsGenerator, args);
babelHelpers.applyConstructor(ActionsGenerator, argsForConstructor);
})();
} else {
assign(actions, ActionsClass);
Expand Down Expand Up @@ -623,7 +623,11 @@ var Alt = (function () {
// Instance type methods for injecting alt into your application as context

value: function addActions(name, ActionsClass) {
this.actions[name] = Array.isArray(ActionsClass) ? this.generateActions.apply(this, ActionsClass) : this.createActions(ActionsClass);
for (var _len = arguments.length, args = Array(_len > 2 ? _len - 2 : 0), _key = 2; _key < _len; _key++) {
args[_key - 2] = arguments[_key];
}

this.actions[name] = Array.isArray(ActionsClass) ? this.generateActions.apply(this, ActionsClass) : this.createActions.apply(this, [ActionsClass].concat(args));
}
},
addStore: {
Expand Down
Loading

0 comments on commit 5dac8e8

Please sign in to comment.