Skip to content

Commit

Permalink
Configure eslint and fix linting errors
Browse files Browse the repository at this point in the history
- Based on airbnb's js style guide
  • Loading branch information
jdlehman committed May 3, 2015
1 parent 2589b67 commit d6760dd
Show file tree
Hide file tree
Showing 16 changed files with 224 additions and 230 deletions.
172 changes: 172 additions & 0 deletions .eslintrc
@@ -0,0 +1,172 @@
{
"env": {
"node": true,
"es6": true
},
"ecmaFeatures": {
"modules": true
},
"rules": {
/* airbnb javascript style guide rules */
"strict": [2, "never"],
// es6
"no-var": 0,
// variables
"no-shadow": 2,
"no-shadow-restricted-names": 2,
"no-unused-vars": [2, {
"vars": "local",
"args": "after-used"
}],
"no-use-before-define": 2,
// possible errors
"comma-dangle": [2, "never"],
"no-cond-assign": [2, "always"],
"no-console": 1,
"no-debugger": 1,
"no-alert": 1,
"no-constant-condition": 1,
"no-dupe-keys": 2,
"no-duplicate-case": 2,
"no-empty": 2,
"no-ex-assign": 2,
"no-extra-boolean-cast": 0,
"no-extra-semi": 2,
"no-func-assign": 2,
"no-inner-declarations": 2,
"no-invalid-regexp": 2,
"no-irregular-whitespace": 2,
"no-obj-calls": 2,
"no-reserved-keys": 2,
"no-sparse-arrays": 2,
"no-unreachable": 2,
"use-isnan": 2,
"block-scoped-var": 2,
// best practices
"consistent-return": 2,
"curly": [2, "multi-line"],
"default-case": 2,
"dot-notation": [2, {
"allowKeywords": true
}],
"eqeqeq": 2,
"guard-for-in": 2,
"no-caller": 2,
"no-eq-null": 2,
"no-eval": 2,
"no-extend-native": 2,
"no-extra-bind": 2,
"no-fallthrough": 2,
"no-floating-decimal": 2,
"no-implied-eval": 2,
"no-lone-blocks": 2,
"no-loop-func": 2,
"no-multi-str": 2,
"no-native-reassign": 2,
"no-new": 2,
"no-new-func": 2,
"no-new-wrappers": 2,
"no-octal": 2,
"no-octal-escape": 2,
"no-param-reassign": 2,
"no-proto": 2,
"no-redeclare": 2,
"no-return-assign": 2,
"no-script-url": 2,
"no-self-compare": 2,
"no-sequences": 2,
"no-throw-literal": 2,
"no-with": 2,
"radix": 2,
"vars-on-top": 2,
"wrap-iife": [2, "any"],
"yoda": 2,
// style
"indent": [2, 2],
"brace-style": [2,
"1tbs", {
"allowSingleLine": true
}],
"quotes": [
2, "single", "avoid-escape"
],
"camelcase": [2, {
"properties": "never"
}],
"comma-spacing": [2, {
"before": false,
"after": true
}],
"comma-style": [2, "last"],
"eol-last": 2,
"key-spacing": [2, {
"beforeColon": false,
"afterColon": true
}],
"new-cap": [2, {
"newIsCap": true
}],
"no-multiple-empty-lines": [2, {
"max": 2
}],
"no-nested-ternary": 2,
"no-new-object": 2,
"no-spaced-func": 2,
"no-trailing-spaces": 2,
"no-wrap-func": 2,
"no-underscore-dangle": 0,
"one-var": [2, "never"],
"padded-blocks": [2, "never"],
"semi-spacing": [2, {
"before": false,
"after": true
}],
"space-after-keywords": 2,
"space-before-blocks": 2,
"space-before-function-paren": [2, "never"],
"space-infix-ops": 2,
"space-return-throw-case": 2,
"spaced-line-comment": 2,

/* custom styles */
"semi": [2, "never"],
"func-names": 0,
"consistent-this": [2, "this"],
"func-style": [0, "expression"],
"generator-star": [2, "end"],
"max-nested-callbacks": [2, 3],
"new-parens": 2,
"no-array-constructor": 2,
"no-else-return": 0,
"no-inline-comments": 2,
"no-lonely-if": 2,
"no-mixed-spaces-and-tabs": [2, "always"],
"no-multiple-empty-lines": [1, {
"max": 2
}],
"no-ternary": 0,
"operator-assignment": 0,
"quote-props": [2, "as-needed"],
"sort-vars": [0, {
"ignoreCase": true
}],
"space-in-brackets": [0, "never",
{
"arraysInArrays": false,
"arraysInObjects": false,
"singleValue": false,
"objectsInArrays": false,
"objectsInObjects": false,
"propertyName": false
}
],
"space-in-parens": [2, "never"],
"space-unary-ops": [2,
{
"words": true,
"nonwords": false
}
],
"wrap-regex": [2, "never"]
}
}
2 changes: 1 addition & 1 deletion components/AltContainer.js
Expand Up @@ -61,7 +61,7 @@ var assign = require('object-assign')
var AltContainer = React.createClass(assign({
displayName: 'AltContainer',

render: function () {
render: function() {
return this.altRender('div')
}
}, mixinContainer(React)))
Expand Down
2 changes: 1 addition & 1 deletion components/AltNativeContainer.js
Expand Up @@ -10,7 +10,7 @@ var assign = require('object-assign')
var AltNativeContainer = React.createClass(assign({
displayName: 'AltNativeContainer',

render: function () {
render: function() {
return this.altRender(React.View)
}
}, mixinContainer(React)))
Expand Down
51 changes: 24 additions & 27 deletions components/mixinContainer.js
Expand Up @@ -25,67 +25,65 @@ function mixinContainer(React) {
flux: React.PropTypes.object
},

getChildContext: function () {
getChildContext: function() {
var flux = this.props.flux || this.context.flux
return flux ? { flux: flux } : {}
},

getInitialState: function () {
getInitialState: function() {
if (this.props.stores && this.props.store) {
throw new ReferenceError('Cannot define both store and stores')
}

return this.reduceState(this.props)
},

componentWillReceiveProps: function (nextProps) {
componentWillReceiveProps: function(nextProps) {
this.destroySubscriptions()
this.setState(this.reduceState(nextProps))
this.registerStores(nextProps)
},

componentDidMount: function () {
componentDidMount: function() {
this.registerStores(this.props)
},

componentWillUnmount: function () {
componentWillUnmount: function() {
this.destroySubscriptions()
},

registerStores: function (props) {
registerStores: function(props) {
var stores = props.stores
Subscribe.create(this)

if (props.store) {
this.addSubscription(props.store)
} else if (props.stores) {
var stores = props.stores

if (Array.isArray(stores)) {
stores.forEach(function (store) {
stores.forEach(function(store) {
this.addSubscription(store)
}, this)
} else {
Object.keys(stores).forEach(function (formatter) {
Object.keys(stores).forEach(function(formatter) {
this.addSubscription(stores[formatter])
}, this)
}
}
},

destroySubscriptions: function () {
destroySubscriptions: function() {
Subscribe.destroy(this)
},

getStateFromStores: function (props) {
getStateFromStores: function(props) {
var stores = props.stores
if (props.store) {
return getStateFromStore(props.store, props)
} else if (props.stores) {
var stores = props.stores

// If you pass in an array of stores then we are just listening to them
// it should be an object then the state is added to the key specified
if (!Array.isArray(stores)) {
return Object.keys(stores).reduce(function (obj, key) {
return Object.keys(stores).reduce(function(obj, key) {
obj[key] = getStateFromStore(stores[key], props)
return obj
}, {})
Expand All @@ -95,17 +93,17 @@ function mixinContainer(React) {
}
},

getStateFromActions: function (props) {
getStateFromActions: function(props) {
if (props.actions) {
return getStateFromKey(props.actions, props)
} else {
return {}
}
},

getInjected: function (props) {
getInjected: function(props) {
if (props.inject) {
return Object.keys(props.inject).reduce(function (obj, key) {
return Object.keys(props.inject).reduce(function(obj, key) {
obj[key] = getStateFromKey(props.inject[key], props)
return obj
}, {})
Expand All @@ -114,7 +112,7 @@ function mixinContainer(React) {
}
},

reduceState: function (props) {
reduceState: function(props) {
return assign(
{},
this.getStateFromStores(props),
Expand All @@ -123,19 +121,19 @@ function mixinContainer(React) {
)
},

addSubscription: function (store) {
addSubscription: function(store) {
if (typeof store === 'function') {
Subscribe.add(this, store(this.props).store, this.altSetState)
} else {
Subscribe.add(this, store, this.altSetState)
}
},

altSetState: function () {
altSetState: function() {
this.setState(this.reduceState(this.props))
},

getProps: function () {
getProps: function() {
var flux = this.props.flux || this.context.flux
var transform = typeof this.props.transform === 'function'
? this.props.transform
Expand All @@ -146,25 +144,24 @@ function mixinContainer(React) {
))
},

shouldComponentUpdate: function () {
shouldComponentUpdate: function() {
return this.props.shouldComponentUpdate
? this.props.shouldComponentUpdate(this.getProps())
: true
},

altRender: function (Node) {
altRender: function(Node) {
var children = this.props.children
// Custom rendering function
if (typeof this.props.render === 'function') {
return this.props.render(this.getProps())
} else if (this.props.component) {
return React.createElement(this.props.component, this.getProps())
}

var children = this.props.children

// Does not wrap child in a div if we don't have to.
if (Array.isArray(children)) {
return React.createElement(Node, null, children.map(function (child, i) {
return React.createElement(Node, null, children.map(function(child, i) {
return cloneWithProps(child, assign({ key: i }, this.getProps()))
}, this))
} else if (children) {
Expand Down

0 comments on commit d6760dd

Please sign in to comment.