Add store testing documentation #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| } | ||
|
|
||
| static getInventory() { | ||
| return this.pets; |
|
Rebased with test fixes, and everything is passing now. |
|
|
||
| One thing we can do is to test our class before it is wrapped by alt, the unwrapped class. We should trust the alt library to test its own internals, so we can just test the inaccessible methods in our plain class by exporting it separately from our alt wrapped store (via `alt.createStore`). To do this, we can export it as a separate file, or use a named export for our unwrapped class and the default export for our alt wrapped class (in the example below, I will use the latter for simplicity). | ||
|
|
||
| Another method to get at the unwrapped class is to do something like `AltWrappedStore[Object.getOwnPropertySymbols(AltWrappedStore)[2]]` as detailed [here](https://gist.github.com/troutowicz/d9dcb7e7e9e77032f602). |
There was a problem hiding this comment.
We should remove this, while it's clever it's not recommended since the symbol may change indices in the future.
goatslacker
added a commit
that referenced
this pull request
Mar 9, 2015
Add store testing documentation
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves Issue #45. Sets up folder in docs for testing documentation.