Skip to content

Commit

Permalink
tenants: really ensure default tenant cannot be deleted (#8875)
Browse files Browse the repository at this point in the history
  • Loading branch information
rissson committed Mar 11, 2024
1 parent ed39123 commit ee275d3
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 5 deletions.
5 changes: 0 additions & 5 deletions authentik/tenants/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,6 @@ def save(self, *args, **kwargs):
raise IntegrityError("Cannot create schema named template")
super().save(*args, **kwargs)

def delete(self, *args, **kwargs):
if self.schema_name in ("public", "template"):
raise IntegrityError("Cannot delete schema public or template")
super().delete(*args, **kwargs)

@property
def serializer(self) -> Serializer:
from authentik.tenants.api.tenants import TenantSerializer
Expand Down
14 changes: 14 additions & 0 deletions authentik/tenants/signals.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
"""authentik tenants signals"""

from django.db import models
from django.db.models.signals import pre_delete
from django.dispatch import receiver
from django_tenants.utils import get_public_schema_name

from authentik.tenants.models import Tenant


@receiver(pre_delete, sender=Tenant)
def tenants_ensure_no_default_delete(sender, instance: Tenant, **kwargs):
if instance.schema_name == get_public_schema_name():
raise models.ProtectedError("Cannot delete schema public", instance)

0 comments on commit ee275d3

Please sign in to comment.